You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (JIRA)" <ji...@apache.org> on 2011/08/18 02:41:27 UTC
[jira] [Created] (THRIFT-1273) Replace assignment of a negative
literal to an
Replace assignment of a negative literal to an
------------------------------------------------
Key: THRIFT-1273
URL: https://issues.apache.org/jira/browse/THRIFT-1273
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments: 0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff
>From 7f84cde1fd531bdae8c0e423e97e34c69a56197b Mon Sep 17 00:00:00 2001
From: [internal fb thing] Stein <st...@fb.com>
Date: Thu, 25 Feb 2010 23:07:15 +0000
Subject: [PATCH 05/33] Replace assignment of a negative literal to an
unsigned int with assignment of an unsigned int
Summary: I have been using this file in [internal fb thing], and it causes compiler
warnings. The compiler gets upset because negative literals are
being assigned to unsigned types. This diff replaces the negative
literals with unsigned bitwise equivalents.
Test Plan: I wrote a program that checks the bitwise equivalence of the
array before and after. I also used the base64 encode and decode
functions before and after, with equivalent results.
---
lib/cpp/src/protocol/TBase64Utils.cpp | 32 ++++++++++++++++----------------
1 files changed, 16 insertions(+), 16 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1273) Replace assignment of a negative
literal to an
Posted by "Dave Watson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Watson updated THRIFT-1273:
--------------------------------
Attachment: 0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff
> Replace assignment of a negative literal to an
> ------------------------------------------------
>
> Key: THRIFT-1273
> URL: https://issues.apache.org/jira/browse/THRIFT-1273
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff
>
>
> From 7f84cde1fd531bdae8c0e423e97e34c69a56197b Mon Sep 17 00:00:00 2001
> From: [internal fb thing] Stein <st...@fb.com>
> Date: Thu, 25 Feb 2010 23:07:15 +0000
> Subject: [PATCH 05/33] Replace assignment of a negative literal to an
> unsigned int with assignment of an unsigned int
> Summary: I have been using this file in [internal fb thing], and it causes compiler
> warnings. The compiler gets upset because negative literals are
> being assigned to unsigned types. This diff replaces the negative
> literals with unsigned bitwise equivalents.
> Test Plan: I wrote a program that checks the bitwise equivalence of the
> array before and after. I also used the base64 encode and decode
> functions before and after, with equivalent results.
> ---
> lib/cpp/src/protocol/TBase64Utils.cpp | 32 ++++++++++++++++----------------
> 1 files changed, 16 insertions(+), 16 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1273) Replace assignment of a negative
literal to an
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167204#comment-13167204 ]
Hudson commented on THRIFT-1273:
--------------------------------
Integrated in Thrift #360 (See [https://builds.apache.org/job/Thrift/360/])
THRIFT-1273 Replace assignment of a negative literal to an
unsigned int with assignment of an unsigned int
Patch: Dave Watson
roger : http://svn.apache.org/viewvc/?view=rev&rev=1213055
Files :
* /thrift/trunk/lib/cpp/src/protocol/TBase64Utils.cpp
> Replace assignment of a negative literal to an
> ------------------------------------------------
>
> Key: THRIFT-1273
> URL: https://issues.apache.org/jira/browse/THRIFT-1273
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Attachments: 0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff
>
>
> From 7f84cde1fd531bdae8c0e423e97e34c69a56197b Mon Sep 17 00:00:00 2001
> From: [internal fb thing] Stein <st...@fb.com>
> Date: Thu, 25 Feb 2010 23:07:15 +0000
> Subject: [PATCH 05/33] Replace assignment of a negative literal to an
> unsigned int with assignment of an unsigned int
> Summary: I have been using this file in [internal fb thing], and it causes compiler
> warnings. The compiler gets upset because negative literals are
> being assigned to unsigned types. This diff replaces the negative
> literals with unsigned bitwise equivalents.
> Test Plan: I wrote a program that checks the bitwise equivalence of the
> array before and after. I also used the base64 encode and decode
> functions before and after, with equivalent results.
> ---
> lib/cpp/src/protocol/TBase64Utils.cpp | 32 ++++++++++++++++----------------
> 1 files changed, 16 insertions(+), 16 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1273) Replace assignment of a negative
literal to an
Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1273.
---------------------------------
Resolution: Fixed
Assignee: Dave Watson
Thanks Dave, committed!
I had the same warnings, with the usage of c++ standard tests (THRIFT-1458).
-Roger
> Replace assignment of a negative literal to an
> ------------------------------------------------
>
> Key: THRIFT-1273
> URL: https://issues.apache.org/jira/browse/THRIFT-1273
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Attachments: 0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff
>
>
> From 7f84cde1fd531bdae8c0e423e97e34c69a56197b Mon Sep 17 00:00:00 2001
> From: [internal fb thing] Stein <st...@fb.com>
> Date: Thu, 25 Feb 2010 23:07:15 +0000
> Subject: [PATCH 05/33] Replace assignment of a negative literal to an
> unsigned int with assignment of an unsigned int
> Summary: I have been using this file in [internal fb thing], and it causes compiler
> warnings. The compiler gets upset because negative literals are
> being assigned to unsigned types. This diff replaces the negative
> literals with unsigned bitwise equivalents.
> Test Plan: I wrote a program that checks the bitwise equivalence of the
> array before and after. I also used the base64 encode and decode
> functions before and after, with equivalent results.
> ---
> lib/cpp/src/protocol/TBase64Utils.cpp | 32 ++++++++++++++++----------------
> 1 files changed, 16 insertions(+), 16 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira