You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/09 13:51:06 UTC
[GitHub] [hbase-thirdparty] jojochuang opened a new pull request #15:
HBASE-19256. [hbase-thirdparty] shade jetty.
jojochuang opened a new pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15
Add Jetty 9.4.27 so HBase can update from Jetty 9.3 to 9.4.
There are multiple benefits with this update:
(1) Jetty 9.3 has known vulnerabilities.
(2) Jetty 9.4 supports TLS 1.3.
(3) Support latest Hadoop versions (HADOOP-16152)
Shade Jetty (org.eclipse.jetty.*) to make HBase co-exist with Hadoop.
Because the Jetty API is used by glassfish libraries, I had to shade org.glassfish.jersey (as well as its dependencies) too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] busbey commented on a change in pull request
#15: HBASE-19256. [hbase-thirdparty] shade jetty.
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389694321
##########
File path: hbase-shaded-miscellaneous/pom.xml
##########
@@ -89,6 +89,38 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>javax</pattern>
Review comment:
this is dangerous because the javax package is special within the JDK specs. classes in this package should be part of the JDK or a JSR, so ideally we wouldn't need to shade them.
what is this trying to relocate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] busbey commented on issue #15: HBASE-19256.
[hbase-thirdparty] shade jetty.
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#issuecomment-596537050
given the size of jetty + glassfish + etc, I'd rather a new module / artifact.
Do you know off hand if this version of jetty still works with jdk7? if so we'll probably want to adopt this artifact in branch-1 too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] jojochuang commented on a change in pull request
#15: HBASE-19256. [hbase-thirdparty] shade jetty.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389785069
##########
File path: hbase-shaded-miscellaneous/pom.xml
##########
@@ -89,6 +89,38 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>javax</pattern>
Review comment:
sure no worries. This work is only meant make the community understand the scope of change, and whether or not we should do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] jojochuang commented on issue #15: HBASE-19256.
[hbase-thirdparty] shade jetty.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#issuecomment-596536286
Please leave a feedback. I'd like to know if this looks okay -- whether it is okay to shade into hbase-shaded-misc jar or shade into a new thirdparty jar (hbase-shadedjetty).
I know I need to bump version. Can do that later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] busbey commented on a change in pull request
#15: HBASE-19256. [hbase-thirdparty] shade jetty.
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389760143
##########
File path: hbase-shaded-miscellaneous/pom.xml
##########
@@ -89,6 +89,38 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>javax</pattern>
Review comment:
Let me put aside some time to see what they are. Maybe middle to end of this week?
My guess would be they're either JSR for web services or some related JEE thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-thirdparty] jojochuang commented on a change in pull request
#15: HBASE-19256. [hbase-thirdparty] shade jetty.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389723993
##########
File path: hbase-shaded-miscellaneous/pom.xml
##########
@@ -89,6 +89,38 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>javax</pattern>
Review comment:
thanks for the comment!
there are a bunch of javax.* classes in jetty and glassfish for the reason i don't know. maybe they are shaded in jetty/glassfish but they don't relocate them?
would you suggest i ignore these javax classes in hbase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services