You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kant2002 <gi...@git.apache.org> on 2015/07/07 15:06:34 UTC
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-docs/pull/295
CB-9295 Add GA analytics code on the Cordova Docs page
GA code added to all templates
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-docs CB-9295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit c5426ca3c5eb97cdb5f7c00b53cff89c46ab3046
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2015-07-07T12:55:15Z
Add GA analytics code on the Cordova Docs page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119435419
We don't care about the old GA tracking ID - in fact we do not have a way to even access it. As for the custom events, I'm new to google analytics but since they lead to navigations which are also tracked in GA, not sure if there is much value in adding custom events.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119256314
Looks like https://github.com/apache/cordova-docs/blob/master/template/docs/default/index.js already has GA code. We should just re-use it and add the correct the ID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119730497
I see - I can take a stab at updating all the older versions on the svn repo that has our website.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119256641
Any ideas on how we can update older versions of the docs to use this new ID? Is it just a find and replace job?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119400706
I also change from the old GA format to new. But we have to verify that both codes working. and as around about PhoneGap tracking code, do Adobe still use it?
One more thing which I could implement is add recording of events on following occasions
1. User change language
2. User select topic in the subheader select.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 closed the pull request at:
https://github.com/apache/cordova-docs/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119465537
To update the file index.js should be distributed to all versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119734040
I merged this one 2f620e6. I had a typo in my commit message and this PR remained open. Can you please close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119442986
So if I could safely remove that old ID, I will do that. Any chance that somebody from Adobe has access and use it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119465461
Ok, so I drop it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119734093
Thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119443684
@stevengill tried to find if anyone could get access to it, but did not find the correct owner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-docs/pull/295#issuecomment-119398888
If I will use code in the index.js, we have to update only index.js files across all versions and we are all set. (not sure about very old (<2.0) English versions. I will move code from index.html to index.js. This should be enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org