[GitHub] [hive] kgyrtkirk commented on a change in pull request #1684: HIVE-21843: UNION query with regular expressions for column name does not work

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #1684:
URL: https://github.com/apache/hive/pull/1684#discussion_r533217084



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -4453,7 +4452,7 @@ private boolean isAggregateInSelect(Node node, Collection<ASTNode> aggregateFunc
    * Returns whether the pattern is a regex expression (instead of a normal
    * string). Normal string is a string with all alphabets/digits and "_".
    */
-  boolean isRegex(String pattern, HiveConf conf) {
+  static boolean isRegex(String pattern, HiveConf conf) {

Review comment:
       this patch adds a call to this method from `ParseUtils`  ; that's why it was neccessary to change it to at least `static`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org