You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/07 12:56:10 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11950: fix(alerts, thumbnails): celery tasks using flask-sqlalchemy sessions
codecov-io edited a comment on pull request #11950:
URL: https://github.com/apache/incubator-superset/pull/11950#issuecomment-739901206
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=h1) Report
> Merging [#11950](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=desc) (f405996) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `0.50%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11950 +/- ##
==========================================
- Coverage 64.45% 63.95% -0.51%
==========================================
Files 937 465 -472
Lines 45319 28550 -16769
Branches 4317 0 -4317
==========================================
- Hits 29211 18259 -10952
+ Misses 15948 10291 -5657
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.95% <63.63%> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | `42.42% <20.00%> (-0.91%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.94%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [477 more](https://codecov.io/gh/apache/incubator-superset/pull/11950/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=footer). Last update [a7bba92...f405996](https://codecov.io/gh/apache/incubator-superset/pull/11950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org