You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/06/27 02:37:08 UTC

Re: Review Request 35912: Updated createdStatusUpdate to take an optional UUID.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35912/
-----------------------------------------------------------

(Updated June 27, 2015, 12:37 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
-------

Vinod's feedback.


Summary (updated)
-----------------

Updated createdStatusUpdate to take an optional UUID.


Bugs: MESOS-2940
    https://issues.apache.org/jira/browse/MESOS-2940


Repository: mesos


Description
-------

This generates the performance improvements shown in MESOS-2940.

Now we only set the UUID when the source is not SOURCE_MASTER.
The existing scheduler driver ignores the 'uuid' field when an update is generated by the master ('pid' == UPID()).


Diffs (updated)
-----

  src/common/protobuf_utils.hpp 9ecd2343689252af1b997392ec367d14d55ac7d1 
  src/common/protobuf_utils.cpp bd6996159e73bf63bb7c2fa3a28def6a2be92b1b 
  src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df 
  src/sched/sched.cpp bc76c71ae9d44bdddd291049223366e38cb0fd0c 
  src/slave/slave.cpp b3e1ccc28d2698d8bc91829d70787dc2fc17b80d 
  src/tests/fault_tolerance_tests.cpp fb28e2afd19d9e9141596767b1d48363e6cce5dc 
  src/tests/partition_tests.cpp f7ee3abe321e9a44913ce5418c9ad9fda0cb3974 

Diff: https://reviews.apache.org/r/35912/diff/


Testing
-------

make check

Ran the benchmark per MESOS-2940.


Thanks,

Ben Mahler