You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/01/31 17:12:25 UTC
[GitHub] gianm commented on issue #6932: Raw byte values should not be used
in bitwise operations in combination with shifts.
gianm commented on issue #6932: Raw byte values should not be used in bitwise operations in combination with shifts.
URL: https://github.com/apache/incubator-druid/pull/6932#issuecomment-459426511
Wouldn't the `lowerNibble` calculation have the same problem? And is this really a bug (do we expect the value to be greater than 127)? I am not too familiar with how this code works so I can't say the answer to that last question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org