You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "fresh-borzoni (via GitHub)" <gi...@apache.org> on 2026/10/04 02:13:36 UTC
[PR] [cpp] Allow sharing one Lookuper across threads [fluss]
fresh-borzoni opened a new pull request, #4541:
URL: https://github.com/apache/fluss/pull/4541
closes https://github.com/apache/fluss/issues/4540
A C++ `Lookuper::Lookup` call blocks until its result arrives, and each lookup waits for the 100 ms batch window. The method is non-const and the bridge takes `&mut self`, so a program can't share one lookuper between threads; calling it from several threads would be undefined behaviour on the Rust side.
Since #4500 the core lookupers take `&self`. This change does the same in the C++ bridge, checks at compile time that both lookuper types are `Sync`, makes `Lookup` and `PrefixLookup` `const`, and documents that threads may share one lookuper. Their concurrent lookups then go out to the server in the same batches. Existing callers compile unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cpp] Allow sharing one Lookuper across threads [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni merged PR #4541:
URL: https://github.com/apache/fluss/pull/4541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cpp] Allow sharing one Lookuper across threads [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #4541:
URL: https://github.com/apache/fluss/pull/4541#issuecomment-5975809410
@charlesdong1991 @leekeiabstraction PTAL 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org