You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by "rs287 (via GitHub)" <gi...@apache.org> on 2023/06/02 06:51:59 UTC

[GitHub] [incubator-devlake] rs287 opened a new issue, #5353: Adding of oauth request module in nginx config in devlake-ui-config

rs287 opened a new issue, #5353:
URL: https://github.com/apache/incubator-devlake/issues/5353

   ## Question
   Would it be possible to tweak nginx conf file in devlake ui config and add "oauth request module" (for adding OAUTH authorization server), packaged this in helm chart (common step)?
   **nginx.conf** 
   ```
   
   server {
     listen 4000;
     server_name localhost;
     absolute_redirect off;
     ${SERVER_CONF}
   
     location / {
       root /usr/share/nginx/html;
       index index.html;
       try_files $uri /index.html;
     }
   
     location /api/ {
       # OAuth2 authentication
       auth_request /oauth2/auth;
       error_page 401 = /oauth2/error;
   
   
       # Proxy settings
       resolver ${DNS} valid=${DNS_VALID};
       resolver_timeout 3s;
       set $target "${DEVLAKE_ENDPOINT}";
       rewrite /api/(.*) /$1 break;
       proxy_send_timeout 60s;
       proxy_read_timeout 60s;
       proxy_pass ${DEVLAKE_ENDPOINT_PROTO}://$target;
     }
   
     location = /oauth2/auth {
       internal;
       proxy_pass ${AUTH_SERVER_ENDPOINT};
       proxy_pass_request_body off;
       proxy_set_header Content-Length "";
       proxy_set_header X-Original-URI $request_uri;
     }
   ```
   Any help is highly appreciated in checking this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] github-actions[bot] closed issue #5353: Adding of oauth request module in nginx config in devlake-ui-config

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed issue #5353: Adding of oauth request module in nginx config in devlake-ui-config
URL: https://github.com/apache/incubator-devlake/issues/5353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] github-actions[bot] commented on issue #5353: Adding of oauth request module in nginx config in devlake-ui-config

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on issue #5353:
URL: https://github.com/apache/incubator-devlake/issues/5353#issuecomment-1627875852

   This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] github-actions[bot] commented on issue #5353: Adding of oauth request module in nginx config in devlake-ui-config

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on issue #5353:
URL: https://github.com/apache/incubator-devlake/issues/5353#issuecomment-1617029084

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on issue #5353: Adding of oauth request module in nginx config in devlake-ui-config

Posted by "klesh (via GitHub)" <gi...@apache.org>.

klesh commented on issue #5353:
URL: https://github.com/apache/incubator-devlake/issues/5353#issuecomment-1573281884

   @rs287 we recently had some discussions regarding this matter, and we came to believe the [oauth2_proxy](https://github.com/apache/incubator-devlake/issues/5140#issuecomment-1550492466) is a better approach, that is: to set up oauth2_proxy as reverse-proxy before `config-ui`. Because:
   
   1. Not all users need it and the actual settings would be quite different from user to user.
   2. We don't recommend to mount the nginx.conf as well because it will be updated from time to time to support some new features. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org