You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/11/10 00:06:00 UTC
[GitHub] [iceberg] rdblue commented on pull request #1742: Fix decimal scale issue in predicate literals
rdblue commented on pull request #1742:
URL: https://github.com/apache/iceberg/pull/1742#issuecomment-724359855
I agree that option 2 is incorrect so we should go with either 1 or 3. Option 1 is definitely conservative. I can't think of any reason why option 3 would be dangerous, given that we can compare decimals with different scales. I think we can move forward with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org