You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/06/04 00:59:48 UTC
Re: Review Request 32755: [3/5] Added a memory statistics test for
memory-mapped file.
> On April 8, 2015, 6:44 p.m., Ian Downes wrote:
> > src/tests/memory_test_helper.cpp, lines 191-194
> > <https://reviews.apache.org/r/32755/diff/1/?file=913063#file913063line191>
> >
> > What happens to this test if /tmp is a tmpfs? Do the cache pages get accounted differently
Tested with /tmp mounted as tmpfs. Accounting is the same.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32755/#review79389
-----------------------------------------------------------
On April 1, 2015, 11:15 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32755/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2572
> https://issues.apache.org/jira/browse/mesos-2572
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a memory statistics test for memory-mapped file.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
> src/tests/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207
> src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
>
> Diff: https://reviews.apache.org/r/32755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>