[GitHub] [pulsar] Technoboy- commented on a diff in pull request #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects

["Technoboy- (via GitHub)" <gi...@apache.org>]

Technoboy- commented on code in PR #21081:
URL: https://github.com/apache/pulsar/pull/21081#discussion_r1309543104


##########
pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java:
##########
@@ -1877,4 +1877,68 @@ public void testReceiverQueueSize() throws Exception {
         consumer.close();
         producer.close();
     }
+
+    @Test
+    public void testCompactionDuplicate() throws Exception {
+        String topic = "persistent://my-property/use/my-ns/testCompactionDuplicate";
+        final int numMessages = 1000;
+        final int maxKeys = 800;
+
+        Producer<byte[]> producer = pulsarClient.newProducer()
+            .topic(topic)
+            .enableBatching(false)
+            .messageRoutingMode(MessageRoutingMode.SinglePartition)
+            .create();

Review Comment:
   Close the `producer`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org