[jira] [Work logged] (AMQNET-637) NMS 2.0

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=725188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725188 ]

ASF GitHub Bot logged work on AMQNET-637:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Feb/22 14:53
            Start Date: 11/Feb/22 14:53
    Worklog Time Spent: 10m 
      Work Description: lukeabsent commented on a change in pull request #18:
URL: https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r804723833



##########
File path: src/Transport/ResponseCorrelator.cs
##########
@@ -85,15 +87,40 @@ public override FutureResponse AsyncRequest(Command command)
 			return future;
         }
 
-        public override Response Request(Command command, TimeSpan timeout)
+        public override Task<Response> RequestAsync(Command command, TimeSpan timeout)
         {
+	        TaskCompletionSource<Response> taskCompletionSource = new TaskCompletionSource<Response>(TaskCreationOptions.RunContinuationsAsynchronously);
+			if (timeout.TotalMilliseconds > 0)
+	        {
+		        CancellationTokenSource ct = new CancellationTokenSource(timeout);

Review comment:
       Not sure, but treid to update it anyway




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 725188)
    Time Spent: 16h 10m  (was: 16h)

> NMS 2.0
> -------
>
>                 Key: AMQNET-637
>                 URL: https://issues.apache.org/jira/browse/AMQNET-637
>             Project: ActiveMQ .Net
>          Issue Type: Improvement
>          Components: NMS
>    Affects Versions: 1.8.0
>            Reporter: Michael Andre Pearce
>            Priority: Major
>             Fix For: API-2.0.0
>
>          Time Spent: 16h 10m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)