[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1242: [HUDI-544] Archived commits command code cleanup

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #1242: [HUDI-544] Archived commits command code cleanup
URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r401971898
 
 

 ##########
 File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
 ##########
 @@ -119,8 +119,10 @@ private[hudi] object HoodieSparkSqlWriter {
 
       // Create the table if not present
       if (!exists) {
+        val archiveLogFolder = parameters.getOrElse(
+          HoodieTableConfig.HOODIE_ARCHIVELOG_FOLDER_PROP_NAME, "archived")
         HoodieTableMetaClient.initTableType(sparkContext.hadoopConfiguration, path.get, tableType,
-          tblName.get, "archived", parameters(PAYLOAD_CLASS_OPT_KEY))
+          tblName.get, archiveLogFolder, parameters(PAYLOAD_CLASS_OPT_KEY))
 
 Review comment:
   @hddong I'm accepting and will merge after you create another ticket for us to add to the release notes that if someone was actually overriding HOODIE_ARCHIVELOG_FOLDER_PROP_NAME that was not being honored before and now will be honored for those cases it can break (since this is the right thing to do)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services