(nuttx) branch master updated: uart_tcsendbreak: Remove cancel point, as tcsendbreak is not one

[xi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new b3f20d4bd6 uart_tcsendbreak: Remove cancel point, as tcsendbreak is not one
b3f20d4bd6 is described below

commit b3f20d4bd6568f9123aad8ddfc00b569a906fbc4
Author: Ville Juven <vi...@unikie.com>
AuthorDate: Mon Nov 13 15:09:48 2023 +0200

    uart_tcsendbreak: Remove cancel point, as tcsendbreak is not one
    
    Reference:
    https://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_09.html
---
 drivers/serial/serial.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index b3ea7e6881..0ae62730d9 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -500,20 +500,6 @@ static int uart_tcsendbreak(FAR uart_dev_t *dev, FAR struct file *filep,
 {
   int ret;
 
-  /* tcsendbreak is a cancellation point */
-
-  if (enter_cancellation_point())
-    {
-#ifdef CONFIG_CANCELLATION_POINTS
-      /* If there is a pending cancellation, then do not perform
-       * the wait.  Exit now with ECANCELED.
-       */
-
-      leave_cancellation_point();
-      return -ECANCELED;
-#endif
-    }
-
   /* REVISIT: Do we need to perform the equivalent of tcdrain() before
    * beginning the Break to avoid corrupting the transmit data? If so, note
    * that just calling uart_tcdrain() here would create a race condition,
@@ -553,7 +539,6 @@ static int uart_tcsendbreak(FAR uart_dev_t *dev, FAR struct file *filep,
       ret = -ENOTTY;
     }
 
-  leave_cancellation_point();
   return ret;
 }