[GitHub] [kafka] hachikuji commented on a diff in pull request #12157: MINOR: Support co-resident mode in KRaft TestKit

[GitBox <gi...@apache.org>]

hachikuji commented on code in PR #12157:
URL: https://github.com/apache/kafka/pull/12157#discussion_r882179407


##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -150,15 +150,16 @@ public KafkaClusterTestKit build() throws Exception {
                     ThreadUtils.createThreadFactory("KafkaClusterTestKit%d", false));
                 for (ControllerNode node : nodes.controllerNodes().values()) {
                     Map<String, String> props = new HashMap<>(configProps);
-                    props.put(KafkaConfig$.MODULE$.ProcessRolesProp(), "controller");
+                    props.put(KafkaConfig$.MODULE$.ProcessRolesProp(), roles(node.id()));

Review Comment:
   Something that was never quite clear to me is why we bother working with the lower-level `ControllerServer` and `BrokerServer` instances in this class. It seems like it would be simpler to use `KafkaRaftServer` which is already doing the dirty work of building `KafkaRaftManager` and the server objects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org