You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/21 05:22:49 UTC
[GitHub] [commons-ognl] arturobernalg opened a new pull request #44: Make final var.
arturobernalg opened a new pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart merged pull request #44: Make final var.
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart commented on pull request #44: Make final var.
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44#issuecomment-864739293
This won't work, some of these `static`s are used to keep state
```
Error: /home/runner/work/commons-ognl/commons-ognl/src/main/java/org/apache/commons/ognl/OgnlContext.java:[114,17] cannot assign a value to final variable DEFAULT_TRACE_EVALUATIONS
Error: /home/runner/work/commons-ognl/commons-ognl/src/main/java/org/apache/commons/ognl/OgnlContext.java:[119,17] cannot assign a value to final variable DEFAULT_KEEP_LAST_EVALUATION
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] arturobernalg commented on pull request #44: Make final var.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44#issuecomment-864742299
> This won't work, some of these `static`s are used to keep state
>
> ```
> Error: /home/runner/work/commons-ognl/commons-ognl/src/main/java/org/apache/commons/ognl/OgnlContext.java:[114,17] cannot assign a value to final variable DEFAULT_TRACE_EVALUATIONS
> Error: /home/runner/work/commons-ognl/commons-ognl/src/main/java/org/apache/commons/ognl/OgnlContext.java:[119,17] cannot assign a value to final variable DEFAULT_KEEP_LAST_EVALUATION
> ```
reverted.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org