You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2008/08/04 16:23:17 UTC
Re: [PATCH] Doc strings for WC log file processing functions
On Tue, 2008-07-29 at 17:14 +0100, Julian Foad wrote:
> While investigating Stefan Kung's crash, I found an opportunity to
> improve documentation in libsvn_wc. Every little helps. Could anyone
> read through and let me have any comments, especially on the three
> places I marked "###", before I commit?
>
> Log message and patch attached.
Committed revision 32366, with only one "###" comment, the one noting
that file_xfer_under_path()'s "special_only" parameter is ignored.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Doc strings for WC log file processing functions
Posted by Julian Foad <ju...@btopenworld.com>.
On Tue, 2008-08-05 at 13:02 -0400, Karl Fogel wrote:
> Julian Foad <ju...@btopenworld.com> writes:
> > On Tue, 2008-07-29 at 17:14 +0100, Julian Foad wrote:
> >> While investigating Stefan Kung's crash, I found an opportunity to
> >> improve documentation in libsvn_wc. Every little helps. Could anyone
> >> read through and let me have any comments, especially on the three
> >> places I marked "###", before I commit?
> >>
> >> Log message and patch attached.
> >
> > Committed revision 32366, with only one "###" comment, the one noting
> > that file_xfer_under_path()'s "special_only" parameter is ignored.
>
> I looked into this a bit: r17495 is the "culprit".
>
> It seems r17495 just meant to undo some of r17362. And r17362
> apparently converted some inline code in file_xfer_under_copy() to call
> svn_wc_translated_file2() instead, and used 'special_only' to decide
> whether or not to pass SVN_WC_TRANSLATE_SPECIAL_ONLY flag to that
> function. When SVN_WC_TRANSLATE_SPECIAL_ONLY got removed in r17495,
> though, we didn't just revert to the old code in file_xfer_under_copy().
OK, thanks for looking.
> (Historical background: the special_only arg was added in r16645, and
> the dependent code introduced with it seems to have remained
> more-or-less in place until r17362.)
>
> r17495 says:
>
> Review by: julianfoad
> malcolm
Ha, so I was here before? I don't remember a thing about it :-)
> Note: Doc string updates still under discussion with Julian;
> to be committed later.
>
> Did this ever happen?
Yes, it did: <http://svn.haxx.se/dev/archive-2005-11/1330.shtml> and
r17535.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Doc strings for WC log file processing functions
Posted by Karl Fogel <kf...@red-bean.com>.
Julian Foad <ju...@btopenworld.com> writes:
> On Tue, 2008-07-29 at 17:14 +0100, Julian Foad wrote:
>> While investigating Stefan Kung's crash, I found an opportunity to
>> improve documentation in libsvn_wc. Every little helps. Could anyone
>> read through and let me have any comments, especially on the three
>> places I marked "###", before I commit?
>>
>> Log message and patch attached.
>
> Committed revision 32366, with only one "###" comment, the one noting
> that file_xfer_under_path()'s "special_only" parameter is ignored.
I looked into this a bit: r17495 is the "culprit".
It seems r17495 just meant to undo some of r17362. And r17362
apparently converted some inline code in file_xfer_under_copy() to call
svn_wc_translated_file2() instead, and used 'special_only' to decide
whether or not to pass SVN_WC_TRANSLATE_SPECIAL_ONLY flag to that
function. When SVN_WC_TRANSLATE_SPECIAL_ONLY got removed in r17495,
though, we didn't just revert to the old code in file_xfer_under_copy().
(Historical background: the special_only arg was added in r16645, and
the dependent code introduced with it seems to have remained
more-or-less in place until r17362.)
r17495 says:
Review by: julianfoad
malcolm
Note: Doc string updates still under discussion with Julian;
to be committed later.
Did this ever happen?
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org