You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/17 05:47:33 UTC

[jira] [Commented] (STORM-1636) Supervisor shutdown with worker id pass in being nil

    [ https://issues.apache.org/jira/browse/STORM-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198730#comment-15198730 ] 

ASF GitHub Bot commented on STORM-1636:
---------------------------------------

GitHub user jerrypeng opened a pull request:

    https://github.com/apache/storm/pull/1226

    [STORM-1636] - Supervisor shutdown with worker id pass in being nil

    In function kill-existing-workers-with-change-in-components in supervisor.clj:
    The function tries to detect whether there is a change in assignment. The bug in this function is that the ordering of the assignment matters but it shouldn't. For example, if a worker assignment is [[1 1] [2 2]] and it changed to [[2 2] [1 1]] it will cause the supervisor to restart the worker

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jerrypeng/storm STORM-1636

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1226
    
----
commit 580ed9d2c4b012701fb6c1a307afe86eaf32863e
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date:   2016-03-17T04:45:42Z

    [STORM-1636] - Supervisor shutdown with worker id pass in being nil

----


>  Supervisor shutdown with worker id pass in being nil 
> ------------------------------------------------------
>
>                 Key: STORM-1636
>                 URL: https://issues.apache.org/jira/browse/STORM-1636
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Boyang Jerry Peng
>            Assignee: Boyang Jerry Peng
>
> In function kill-existing-workers-with-change-in-components in supervisor.clj:
> The function tries to detect whether there is a change in assignment. The bug in this function is that the ordering of the assignment matters but it shouldn't. For example, if a worker assignment is [[1 1] [2 2]] and it changed to [[2 2] [1 1]] it will cause the supervisor to restart the worker



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)