You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2023/02/01 11:12:49 UTC

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19465


Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................

IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

IMPALA-10010 added support for an unsecure webserver also known
as metrics webserver, used for exposing low-sensitivity info.
'/healthz' endpoint was added to impalad's metrics webservers. It
makes sense to also add '/healthz' endpoint to catalogd's and
statestored's metrics webserver.

Testing:
- Updated existing fe test 'testMetricsWebserver' to also test access
to '/healthz' endpoint when metrics webserver is enabled for catalogd
and statestored

Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalogd-main.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/statestore/statestored-main.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
7 files changed, 47 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/19465/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9016/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 12:36:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 3: Code-Review+2

Carryover


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 12:34:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................

IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

IMPALA-10010 added support for an unsecure webserver also known
as metrics webserver, used for exposing low-sensitivity info.
'/healthz' endpoint was added to impalad's metrics webservers. It
makes sense to also add '/healthz' endpoint to catalogd's and
statestored's metrics webserver.

Testing:
- Updated existing fe test 'testMetricsWebserver' to also test access
to '/healthz' endpoint when metrics webserver is enabled for catalogd
and statestored

Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalogd-main.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/statestore/statestored-main.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
7 files changed, 50 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/19465/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................

IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

IMPALA-10010 added support for an unsecure webserver also known
as metrics webserver, used for exposing low-sensitivity info.
'/healthz' endpoint was added to impalad's metrics webservers. It
makes sense to also add '/healthz' endpoint to catalogd's and
statestored's metrics webserver.

Testing:
- Updated existing fe test 'testMetricsWebserver' to also test access
to '/healthz' endpoint when metrics webserver is enabled for catalogd
and statestored

Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Reviewed-on: http://gerrit.cloudera.org:8080/19465
Reviewed-by: Abhishek Rawat <ar...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalogd-main.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/statestore/statestored-main.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
7 files changed, 50 insertions(+), 18 deletions(-)

Approvals:
  Abhishek Rawat: Looks good to me, approved
  Jason Fehr: Looks good to me, but someone else must approve
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:

http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@71
PS1, Line 71:   public void setUp(String extraArgs, String startArgs, String catalogdArgs, String stateStoredArgs) throws Exception {
> line too long (119 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@85
PS1, Line 85:     int ret = CustomClusterRunner.StartImpalaCluster(impalaArgs, catalogdArgs, stateStoredArgs, env, startArgs);
> line too long (112 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@178
PS1, Line 178:         TEST_USER_GROUP, TEST_USER_1, TEST_USER_3, TEST_USER_DN_1, TEST_PASSWORD_1), "", "", "");
> line too long (97 > 90)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 11:17:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:

http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@71
PS1, Line 71:   public void setUp(String extraArgs, String startArgs, String catalogdArgs, String stateStoredArgs) throws Exception {
line too long (119 > 90)


http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@85
PS1, Line 85:     int ret = CustomClusterRunner.StartImpalaCluster(impalaArgs, catalogdArgs, stateStoredArgs, env, startArgs);
line too long (112 > 90)


http://gerrit.cloudera.org:8080/#/c/19465/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@178
PS1, Line 178:         TEST_USER_GROUP, TEST_USER_1, TEST_USER_3, TEST_USER_DN_1, TEST_PASSWORD_1), "", "", "");
line too long (97 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 11:13:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 17:43:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12284/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 11:39:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................

IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

IMPALA-10010 added support for an unsecure webserver also known
as metrics webserver, used for exposing low-sensitivity info.
'/healthz' endpoint was added to impalad's metrics webservers. It
makes sense to also add '/healthz' endpoint to catalogd's and
statestored's metrics webserver.

Testing:
- Updated existing fe test 'testMetricsWebserver' to also test access
to '/healthz' endpoint when metrics webserver is enabled for catalogd
and statestored

Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalogd-main.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/statestore/statestored-main.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
7 files changed, 50 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/19465/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19465/2/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:

http://gerrit.cloudera.org:8080/#/c/19465/2/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@84
PS2, Line 84: +
> nit: would be better to add a whitespace as well: + ' ' +
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 12:33:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

LGTM!

http://gerrit.cloudera.org:8080/#/c/19465/2/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:

http://gerrit.cloudera.org:8080/#/c/19465/2/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@84
PS2, Line 84: +
nit: would be better to add a whitespace as well: + ' ' +



-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 12:19:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12283/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 11:32:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12285/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 12:52:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19465 )

Change subject: IMPALA-11890: Expose 'healthz' endpoint in metrics webserver of statestored and catalogd
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I738d6ff2c579063007ea5ac9a66dbdcd0683f1a7
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 17:22:51 +0000
Gerrit-HasComments: No