You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/26 18:47:39 UTC
[GitHub] [pulsar] andrasbeni opened a new pull request, #17843: [improve][test] Add integration test for websocket
andrasbeni opened a new pull request, #17843:
URL: https://github.com/apache/pulsar/pull/17843
Master Issue: #17132
### Motivation
Increase test coverage of the websocket feature.
### Modifications
- moved the websocket related proxy test to the proxy package and renamed it
- factored out generic code
- added container for external websocket service
- added websocket test methods for broker and external service
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
*Added integration tests for websocket*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- [x] `doc-not-needed`
This change only affects tests
PR in forked repository: https://github.com/andrasbeni/pulsar/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17843: [improve][test] Add integration test for websocket
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17843:
URL: https://github.com/apache/pulsar/pull/17843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17843: [improve][test] Add integration test for websocket
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17843: [improve][test] Add integration test for websocket
URL: https://github.com/apache/pulsar/pull/17843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17843: [improve][test] Add integration test for websocket
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17843:
URL: https://github.com/apache/pulsar/pull/17843#issuecomment-1259704571
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org