You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/24 06:03:51 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9126: add integration-test (dql dml) for broadcast feature

tristaZero commented on a change in pull request #9126:
URL: https://github.com/apache/shardingsphere/pull/9126#discussion_r563243140



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/dql/dql-integration-test-cases.xml
##########
@@ -481,4 +481,8 @@
     <test-case sql="SELECT * FROM t_order o LEFT JOIN t_order_item m ON o.order_id = m.order_id" db-types="MySQL,H2">
         <assertion expected-data-file="select_for_left_join.xml"/>
     </test-case>
+
+<!--    <test-case sql="SELECT * FROM t_broadcast_table">-->

Review comment:
       Is there no needed to have this test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org