You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/06/12 10:25:50 UTC
[GitHub] flink pull request #6152: 9467
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6152
9467
## What is the purpose of the change
This PR fixes the watermark display in the WebUI.
When we reworked the watermark metrics we renamed the metrics and moved them to the operator level.
We never adjusted the UI for these changes. The renaming itself was easy to fix, the move to the operator level less so as the UI is not aware of operators. This showed that the upgrade path from task to operator watermark metrics isn't as easy as it should be. As such, once again, we expose the input watermark also on the task level.
We could have a discussion about exposing all watermark metrics also for tasks, but this is rather involved for the output watermarks. (particularly so since we never planned for it)
## Brief change log
* expose `currentInputWatermark` also for the task
* rename queried metric name in UI
## Verifying this change
* manually verified, start a local cluster, run the `TopSpeedWindowing` example, check watermark tab in UI
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6152
----
commit 6244b11009d6ce0025edd60c1c765432c0bf57f7
Author: zentol <ch...@...>
Date: 2018-06-05T11:51:08Z
[FLINK-9467][metrics][WebUI] Fix watermark display
commit 5d5825166ebc9faea9315e3e0d09cca40d716743
Author: zentol <ch...@...>
Date: 2018-06-05T11:51:29Z
[FLINK-9467][metrics] Rebuild UI
----
---
[GitHub] flink pull request #6152: [FLINK-9467][metrics][WebUI] Fix watermark display...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6152
---
[GitHub] flink issue #6152: [FLINK-9467][metrics][WebUI] Fix watermark display
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6152
merging.
---
[GitHub] flink pull request #6152: [FLINK-9467][metrics][WebUI] Fix watermark display...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6152#discussion_r197086995
--- Diff: docs/monitoring/metrics.md ---
@@ -1228,7 +1228,7 @@ Thus, in order to infer the metric identifier:
<td>Meter</td>
</tr>
<tr>
- <th rowspan="5"><strong>Task/Operator</strong></th>
+ <th rowspan="6"><strong>Task/Operator</strong></th>
--- End diff --
I would put "Task and Operator" rather than "Task/Operator"
---
[GitHub] flink pull request #6152: [FLINK-9467][metrics][WebUI] Fix watermark display...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6152#discussion_r197087153
--- Diff: docs/monitoring/metrics.md ---
@@ -1254,15 +1254,15 @@ Thus, in order to infer the metric identifier:
<td>Counter</td>
</tr>
<tr>
- <th rowspan="5"><strong>Operator</strong></th>
<td>currentInputWatermark</td>
<td>
- The last watermark this operator has received (in milliseconds).
- <p><strong>Note:</strong> For operators with 2 inputs this is the minimum of the last received watermarks.</p>
+ The last watermark this operator/tasks has received (in milliseconds).
+ <p><strong>Note:</strong> For operators/tasks with 2 inputs this is the minimum of the last received watermarks.</p>
</td>
<td>Gauge</td>
</tr>
<tr>
+ <th rowspan="4"><strong>Operator</strong></th>
--- End diff --
I would put "Operator Only" to emphasize the diff with the above.
---