You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by ykopel <gi...@git.apache.org> on 2017/02/19 08:08:34 UTC
[GitHub] trafficserver pull request #1472: condition that cause always passthrough by...
GitHub user ykopel opened a pull request:
https://github.com/apache/trafficserver/pull/1472
condition that cause always passthrough bypass
Fix for apache@497e475.
This commit contains a condition that will always be true.
This is because ua_raw_buffer_reader->read_avail() always will be grater than zero.
You haven't see it until now because of another bug (https://github.com/apache/trafficserver/pull/1471) that cause is_transparent_passthrough_allowed() to be always false and this for it never reached to your lines.
This is why I suggest to just delete those lines meantime.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykopel/trafficserver tr-pass
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1472
----
commit edcd7de1b3b79b3c0da4b717bf13c7395c86646e
Author: Yakov Kopel <ya...@gmail.com>
Date: 2017-02-19T07:55:07Z
condition that cause always passthrough bypass
Fix for apache@497e475.
This commit contains a condition that will always be true.
This is because ua_raw_buffer_reader->read_avail() always will be grater than zero.
You haven't see it until now because of another bug (5817738) that cause is_transparent_passthrough_allowed() to be always false and this for it never reached to your lines.
This is why I suggest to just delete those lines meantime.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/31/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1472
Have you tested this in practice? `ua_buffer_reader->read_avail()` should be zero in most cases, because all of the header has been read and the user agent shouldn't send more data after that if there no is keep alive set (which is also checked).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1493/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1599/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/163/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by ykopel <gi...@git.apache.org>.
Github user ykopel commented on the issue:
https://github.com/apache/trafficserver/pull/1472
I tested it in my env. And I see it is grater than zero.
There are several lines before it that assume that "read_avail" is grater than zero:
```
// Reset the inactivity timeout if this is the first
// time we've been called. The timeout had been set to
// the accept timeout by the ProxyClientTransaction
//
if ((ua_buffer_reader->read_avail() > 0) && (client_request_hdr_bytes == 0)) {
milestones[TS_MILESTONE_UA_FIRST_READ] = Thread::get_hrtime();
ua_session->set_inactivity_timeout(HRTIME_SECONDS(t_state.txn_conf->transaction_no_activity_timeout_in));
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1472
It is fixed by \u201cTS-5103: replace ua_raw_buffer_reader with ua_buffer_reader\u201d
please check the code in master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1472
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1472
"TS-3100: Extend tr-pass to allow malformed HTTP GET requests to be blind tunneled." is added by @shinrich .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---