You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "nicoloboschi (via GitHub)" <gi...@apache.org> on 2023/10/13 07:00:40 UTC
[PR] Add flag to skip doc generation [nifi-maven]
nicoloboschi opened a new pull request, #35:
URL: https://github.com/apache/nifi-maven/pull/35
In https://github.com/LangStream/langstream we use this plugin for producing NAR files. The NAR are then ingested by the LangStream runtime and the documentation is not needed.
Changes:
* Added new boolean configuration flag "skipDocGeneration" (default false) to completely skip the doc generation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add flag to skip doc generation [nifi-maven]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1761123734
Do you mind filing a NIFI JIRA for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1761300835
> Do you mind filing a NIFI JIRA for this change?
done https://issues.apache.org/jira/browse/NIFI-12226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1944190302
It would be nice to have a release where this is included. It would help the Apache Pulsar build too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #35: NIFI-12226: Add flag to skip doc generation
URL: https://github.com/apache/nifi-maven/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1766328766
@nandorsoma It's widely used also in Apache Pulsar for distributing connectors that run over Pulsar IO.
https://pulsar.apache.org/docs/next/functions-package-java/#package-as-nar
The documentation part is useless in Pulsar too so this change improves the build time there too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1767342297
+1 on this PR from me, I can merge unless @nandorsoma wants to :) @nicoloboschi is this the only feature of NiFi that LangStream uses? For LangStream and Pulsar, is it the metadata and/or approach to classloader isolation that makes the NAR format useful? If so I definitely think we should we refactor this to be a generic "extension packager" or something and publish it as such (as @nandorsoma suggested), and we can add NiFi-specific stuff for the NiFi plugin and publish that too.
If we want to get fancy we can accept extensions for doc generation (so it's not NiFi-specific) and even the supported annotations (to make it even more flexible). That's quite a bit of work though, I'd tackle it in my spare time but that's pretty sparse these days. Would be happy to review a "Feature Proposal" on the [wiki](https://cwiki.apache.org/confluence/display/NIFI/NiFi+Feature+Proposals) if someone wanted to put up a requirements and/or design document.
For the "different context" to which Soma is referring, stay tuned and keep an eye on that Feature Proposals page ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add flag to skip doc generation [nifi-maven]
Posted by "nandorsoma (via GitHub)" <gi...@apache.org>.
nandorsoma commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1761020269
> @nandorsoma @kevdoran could you review?
>
>
>
> it would be great to cut a release right after
Sure @nicoloboschi, thanks for the heads-up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add flag to skip doc generation [nifi-maven]
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1761008569
@nandorsoma @kevdoran could you review?
it would be great to cut a release right after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #35:
URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-2116764510
> Thanks for the feedback @mattyb149! Merging to main. Also we should consider a minor release in the near future.
@nandorsoma @mattyb149 Any plans for the next minor release in the near future? The reason why I'm asking is that this feature will be useful in Pulsar where we use nifi-nar-maven-plugin extensively. The doc generation process (only the scannning) consumes a lot of CPU and heap memory and I'd like to eliminate that by using a nifi-nar-maven-plugin version that includes this PR.
/cc @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org