[GitHub] [ozone] aswinshakil commented on a diff in pull request #3498: HDDS-6841. EC: Validate the server default configuration on Ozone manager startup

[GitBox <gi...@apache.org>]

aswinshakil commented on code in PR #3498:
URL: https://github.com/apache/ozone/pull/3498#discussion_r894764892


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -608,6 +612,43 @@ private OzoneManager(OzoneConfiguration conf, StartupOption startupOption)
     }
   }
 

Review Comment:
   We can do this. But `getDefaultReplicationConfig()` already does a validate on `validator.validate(defaultRepConfig)`. Also it does a substition with client side replication config if the server-side field are `null`(Which might not happen as we have server-side defaults). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org