You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/08/23 07:35:50 UTC

[GitHub] codecov-io commented on issue #429: SCB-857 Provider rule of consumer can not be removed

codecov-io commented on issue #429: SCB-857 Provider rule of consumer can not be removed
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/429#issuecomment-415321015
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=h1) Report
   > Merging [#429](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/92a3b48b76ff9cbfbdee5f7730b925fa018fa668?src=pr&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/graphs/tree.svg?width=650&height=150&token=GAaF7zrg8R&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##           master    #429     +/-   ##
   ========================================
   - Coverage    69.2%   69.1%   -0.1%     
   ========================================
     Files         139     139             
     Lines       10770   10770             
   ========================================
   - Hits         7453    7443     -10     
   - Misses       2839    2848      +9     
   - Partials      478     479      +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [server/service/util/dependency\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3V0aWwuZ28=) | `44.47% <0%> (ø)` | :arrow_up: |
   | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: |
   | [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `72.72% <0%> (-9.1%)` | :arrow_down: |
   | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `81.93% <0%> (-1.94%)` | :arrow_down: |
   | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
   | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: |
   | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `91.17% <0%> (+2.94%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=footer). Last update [92a3b48...ceb32a6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/429?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services