You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sam Tunnicliffe (Jira)" <ji...@apache.org> on 2021/03/08 16:39:00 UTC
[jira] [Comment Edited] (CASSANDRA-16498) Python upgrade DTests
fail in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297514#comment-17297514 ]
Sam Tunnicliffe edited comment on CASSANDRA-16498 at 3/8/21, 4:38 PM:
----------------------------------------------------------------------
It looks like it was [this commit|https://github.com/apache/cassandra-builds/commit/29dccda73cec1c80ffa838a3109c8bef68f162ee] for CASSANDRA-16428 and subsequent rebuild of the docker testing images that broke things. The patch removes the {{ENV}} directives which set {{JAVA8_HOME/JAVA11_HOME}} in from the dockerfile and instead echoes the values out to {{.bashrc}}. Circle doesn't source {{.bashrc}} though, so the vars stopped being available to the running steps.
We could restore them to the dockerfile and republish images, but in the meantime I'm taking a look at why adding them to the default env vars in {{config-2.1.yaml}} is a problem. They were originally present there, but a trunk only commit wiped them out (hence why {{JAVA8_HOME}} is still present on the 3.11/3.0 branches.
was (Author: beobal):
It looks like it was [this commit|https://github.com/apache/cassandra-builds/commit/29dccda73cec1c80ffa838a3109c8bef68f162ee] and subsequent rebuild of the docker testing images that broke things. The patch removes the {{ENV}} directives which set {{JAVA8_HOME/JAVA11_HOME}} in from the dockerfile and instead echoes the values out to {{.bashrc}}. Circle doesn't source {{.bashrc}} though, so the vars stopped being available to the running steps.
We could restore them to the dockerfile and republish images, but in the meantime I'm taking a look at why adding them to the default env vars in {{config-2.1.yaml}} is a problem. They were originally present there, but a trunk only commit wiped them out (hence why {{JAVA8_HOME}} is still present on the 3.11/3.0 branches.
> Python upgrade DTests fail in CircleCI
> --------------------------------------
>
> Key: CASSANDRA-16498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16498
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0, 4.0-rc
>
>
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/210/workflows/48230e6d-9fe0-4321-92b0-3709c86c5e16/jobs/1722]
> It seems at some point in time JAVA8_HOME got lost from the CircleCI configuration. Upgrade Tests are not always run so that was missed.
> I tried just to ninja fix JAVA8_HOME by adding it back as part of the default variables as it was there before but then the build fails for Java 11 HIGHRES for missing Jars. It doesn't fail for Java 11 in MIDRES.
> I have to check it further next week.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org