You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/24 14:08:13 UTC
[GitHub] [airflow] GuzikJakub opened a new pull request #7250:
[AIRFLOW-6627] Email with incorrect DAG not delivered
GuzikJakub opened a new pull request #7250: [AIRFLOW-6627] Email with incorrect DAG not delivered
URL: https://github.com/apache/airflow/pull/7250
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
In case of incorrect DAG execution, I did not receive a notification about the erroneous task completion. This was caused by an incorrect encode of the character
I introduced a lock that tries to send an email with an error, adding the exception that when the email fails, it sends information that the logs could not be thrown into the email.
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
Link: https://issues.apache.org/jira/browse/AIRFLOW-6627
- [X ] Unit tests coverage for changes (not needed for documentation changes)
Not needed
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7250:
[AIRFLOW-6627] Email with incorrect DAG not delivered
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7250: [AIRFLOW-6627] Email with incorrect DAG not delivered
URL: https://github.com/apache/airflow/pull/7250#issuecomment-578174502
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=h1) Report
> Merging [#7250](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a3f02c4627c28ad524cca73031670722cd6d8253?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7250 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.29%
==========================================
Files 791 791
Lines 40137 40142 +5
==========================================
- Hits 34252 34143 -109
- Misses 5885 5999 +114
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.71% <66.66%> (-0.25%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=footer). Last update [a3f02c4...60b296d](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7250: [AIRFLOW-6627] Email
with incorrect DAG not delivered
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7250: [AIRFLOW-6627] Email with incorrect DAG not delivered
URL: https://github.com/apache/airflow/pull/7250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7250: [AIRFLOW-6627] Email
with incorrect DAG not delivered
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7250: [AIRFLOW-6627] Email with incorrect DAG not delivered
URL: https://github.com/apache/airflow/pull/7250#issuecomment-578174502
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=h1) Report
> Merging [#7250](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a3f02c4627c28ad524cca73031670722cd6d8253?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7250 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.29%
==========================================
Files 791 791
Lines 40137 40142 +5
==========================================
- Hits 34252 34143 -109
- Misses 5885 5999 +114
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.71% <66.66%> (-0.25%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7250/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=footer). Last update [a3f02c4...60b296d](https://codecov.io/gh/apache/airflow/pull/7250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services