You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tennisleng (via GitHub)" <gi...@apache.org> on 2025/12/06 17:52:44 UTC
[PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
tennisleng opened a new pull request, #48377:
URL: https://github.com/apache/arrow/pull/48377
### Rationale for this change
This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in `ASSERT_DOUBLE_EQ` and `ASSERT_FLOAT_EQ` macros.
Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written).
See: https://github.com/google/googletest/commit/59c924bc471cefea25a7cf7eb40b6c101b170b12
### What changes are included in this PR?
Updated `cpp/thirdparty/versions.txt`:
- `ARROW_GTEST_BUILD_VERSION`: 1.16.0 → 1.17.0
- `ARROW_GTEST_BUILD_SHA256_CHECKSUM`: Updated to match new version
### Are these changes tested?
This is a dependency version update. Existing tests will validate compatibility.
### Are there any user-facing changes?
No.This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros.
Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). This was fixed in GoogleTest commit 59c924bc.
See: https://github.com/google/googletest/commit/59c924bc471cefea25a7cf7eb40b6c101b170b12
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
Please remove this line and the above text before creating your pull request.
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3641113048
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #48377:
URL: https://github.com/apache/arrow/pull/48377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3620823677
:warning: GitHub issue #48376 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3643826424
:warning: GitHub issue #48376 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3641123126
Revision: e60782ec176d15e3c9875e3f07a003cd9a2ba51f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-31a1fe2b5e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-31a1fe2b5e)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878650/job/57765063208)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878620/job/57765063074)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/20128879249/job/57765065554)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878112/job/57765061359)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/20128879179/job/57765065312)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878877/job/57765064222)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878539/job/57765062669)|
|test-cuda-cpp-ubuntu-24.04-cuda-13.0.2|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878833/job/57765063804)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878129/job/57765061094)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878194/job/57765061483)|
|test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878122/job/57765061286)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/20128879331/job/57765065718)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/20128879001/job/57765064545)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878371/job/57765062072)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878511/job/57765062627)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/20128879033/job/57765064606)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878513/job/57765062536)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878865/job/57765064004)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/20128879165/job/57765065233)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878737/job/57765063487)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878520/job/57765062702)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/20128878543/job/57765062646)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3641110165
Thanks for this!
@kou what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3649552738
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 09f156105d34327a5154ccf76595c38c01a9bf2b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/57975945439) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3620826582
:warning: GitHub issue #48376 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48377:
URL: https://github.com/apache/arrow/pull/48377#issuecomment-3641126208
:warning: GitHub issue #48376 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org