You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2025/09/03 16:17:13 UTC

[PR] [WIP][FLINK-XXX][table] potential fix for PushCalcPastChangelogNormalizeRule [flink]

snuyanzin opened a new pull request, #26959:
URL: https://github.com/apache/flink/pull/26959

   ## What is the purpose of the change
   
   TBD
   
   ## Brief change log
   TBD
   
   
   ## Verifying this change
   TBD
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38317][table] PushCalcPastChangelogNormalizeRule fails in case of partial push down and trimmed fields [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26959:
URL: https://github.com/apache/flink/pull/26959#discussion_r2319981372


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/PushCalcPastChangelogNormalizeRule.java:
##########
@@ -326,8 +326,11 @@ private void transformWithRemainingPredicates(
         }
         if (!conditions.isEmpty()) {
             final RexNode condition = relBuilder.and(conditions);
-            programBuilder.addCondition(
-                    FlinkRexUtil.simplify(relBuilder.getRexBuilder(), condition, rexExecutor));
+            final RexNode simplifiedCondition =
+                    FlinkRexUtil.simplify(relBuilder.getRexBuilder(), condition, rexExecutor);
+            if (!condition.isAlwaysTrue()) {
+                programBuilder.addCondition(adjustInputRef(simplifiedCondition, inputRefMapping));

Review Comment:
   need adjusting as it was done several lines above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [WIP][FLINK-XXX][table] potential fix for PushCalcPastChangelogNormalizeRule [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26959:
URL: https://github.com/apache/flink/pull/26959#issuecomment-3249931504

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4ee98534cc6129750b01bab5c212e37f6117bf5c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4ee98534cc6129750b01bab5c212e37f6117bf5c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4ee98534cc6129750b01bab5c212e37f6117bf5c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38317][table] PushCalcPastChangelogNormalizeRule fails in case of partial push down and trimmed fields [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #26959:
URL: https://github.com/apache/flink/pull/26959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org