You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "packyan (via GitHub)" <gi...@apache.org> on 2023/04/16 09:40:41 UTC
[GitHub] [kyuubi] packyan opened a new pull request, #4716: [Improvement] [AUTHZ] Spec json files should be auto generated, rather than edit manually
packyan opened a new pull request, #4716:
URL: https://github.com/apache/kyuubi/pull/4716
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
to close #4715
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4716: [KYUUBI 4715] [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1512588303
@packyan Can I have an offline discussion with you for further details? Are you in one of Wechat discussion group？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] packyan commented on pull request #4716: [KYUUBI 4715] [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "packyan (via GitHub)" <gi...@apache.org>.
packyan commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1511052962
> Alright, but is there any clue why we have to change the name of the plan in the generator rather than just change the generated files?
>
>
In my case, when I was developing function privileges build feature, I needed to use the generator to regenerate spec json files. I trusted the results generated by the generator without checking whether the json had been manually modified. This caused my pr to fail in CI. Although directly modifying the generated json has no effect on users, it is not friendly to developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4716: [KYUUBI 4715] [AUTHZ] Fix the incorrect class name of InsertIntoHiveDirCommand in table spec generator
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1513397766
Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4716: [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1510289456
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4716?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4716](https://codecov.io/gh/apache/kyuubi/pull/4716?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bacf601) into [master](https://codecov.io/gh/apache/kyuubi/commit/db46b5b320ffc3e58f84a0c3bb0d113783b9612b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db46b5b) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4716 +/- ##
============================================
- Coverage 58.11% 58.03% -0.09%
Complexity 13 13
============================================
Files 580 580
Lines 32232 32232
Branches 4302 4302
============================================
- Hits 18731 18705 -26
- Misses 11713 11733 +20
- Partials 1788 1794 +6
```
[see 10 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4716/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4716: [KYUUBI 4715] [AUTHZ] Fix the incorrect class name of InsertIntoHiveDirCommand in table spec generator
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #4716: [KYUUBI 4715] [AUTHZ] Fix the incorrect class name of InsertIntoHiveDirCommand in table spec generator
URL: https://github.com/apache/kyuubi/pull/4716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4716: [KYUUBI 4715] [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1511000946
Alright, but is there any clue why we have to change the name of the plan in the generator rather than just change the generated files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4716: [KYUUBI 4715] [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1510572007
You can referer this PR to change to one-time generator to test suite for check generated golden files.
https://github.com/apache/kyuubi/pull/4677/files#diff-30f8af2f8dfb17df96d4b4da322723a1baf0f9ae5171faa29f23e40206ea9e51R57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] packyan commented on pull request #4716: [KYUUBI 4715] [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "packyan (via GitHub)" <gi...@apache.org>.
packyan commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1510645449
> You can referer this PR to change to one-time generator to test suite for check generated golden files.
>
> #4677
>
>
>
> https://github.com/apache/kyuubi/pull/4677/files#diff-30f8af2f8dfb17df96d4b4da322723a1baf0f9ae5171faa29f23e40206ea9e51R57
Sounds good, I will reference this RP and add a UT for check generated golden files.
But can we merge this bug fix firstly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4716: [KYUUBI 4715] [Bug] [AUTHZ] Fix the inconsistency between the automatically generated json file and the json file in the resources dir
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4716:
URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1512819195
Let's fix the inconsistency in the spec json file in this PR first. And move the regeneration and validation to #4717.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org