You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/09 07:08:32 UTC
[GitHub] [kafka] YeonCheolGit opened a new pull request #11660: MINOR: fix comment in ClusterConnectionStates
YeonCheolGit opened a new pull request #11660:
URL: https://github.com/apache/kafka/pull/11660
Found minor typo in ClusterConnectionStates.java
### More detailed description of your change,
`iff` --> `if`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11660: MINOR: fix comment in ClusterConnectionStates
Posted by GitBox <gi...@apache.org>.
YeonCheolGit commented on a change in pull request #11660:
URL: https://github.com/apache/kafka/pull/11660#discussion_r782195849
##########
File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -68,7 +68,7 @@ public ClusterConnectionStates(long reconnectBackoffMs, long reconnectBackoffMax
}
/**
- * Return true iff we can currently initiate a new connection. This will be the case if we are not
+ * Return true if we can currently initiate a new connection. This will be the case if we are not
Review comment:
@junrao
Oh really didn't know about that. Sorry for interrupt you and thank you for letting me know:)
I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] YeonCheolGit commented on pull request #11660: MINOR: fix comment in ClusterConnectionStates
Posted by GitBox <gi...@apache.org>.
YeonCheolGit commented on pull request #11660:
URL: https://github.com/apache/kafka/pull/11660#issuecomment-1008242993
Call for review @dajac @junrao @guozhangwang @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on a change in pull request #11660: MINOR: fix comment in ClusterConnectionStates
Posted by GitBox <gi...@apache.org>.
junrao commented on a change in pull request #11660:
URL: https://github.com/apache/kafka/pull/11660#discussion_r781655987
##########
File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -68,7 +68,7 @@ public ClusterConnectionStates(long reconnectBackoffMs, long reconnectBackoffMax
}
/**
- * Return true iff we can currently initiate a new connection. This will be the case if we are not
+ * Return true if we can currently initiate a new connection. This will be the case if we are not
Review comment:
iff means if and only if. So, this seems correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] YeonCheolGit closed pull request #11660: MINOR: fix comment in ClusterConnectionStates
Posted by GitBox <gi...@apache.org>.
YeonCheolGit closed pull request #11660:
URL: https://github.com/apache/kafka/pull/11660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org