You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/08/14 06:53:55 UTC
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/116
TAJO-1004: UniformRangePartition cannot deal with unicode ranges.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 8efe5597a553eaab4f4ed8724e7fbae820adbb71
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-08-13T09:38:53Z
initial work.
commit 1a938220a3887ba80031a178d01bf47634cb0339
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-08-14T01:24:09Z
Changing calculate partition num.
commit 7b5a689036c37633e1a47e0ab3b4aa92305b0d99
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-08-14T02:33:12Z
Improved unicode partition.
commit 262c88cfe3edd22ef638f7f077f27110cd93d860
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-08-14T04:21:10Z
Completed and add unit tests.
commit 4239e165315dc375850bc0d445b904aea14f7664
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-08-14T04:52:52Z
Refactored trivial things.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/116#issuecomment-52885509
Thank you for the review. I'll commit it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/116#issuecomment-52750296
I've updated the patch. The updated patch includes some hidden bug fix and unit tests to verify the found bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/116#issuecomment-52881787
Fixed the problem, and I rebased it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/116#issuecomment-52884744
+1
Looks great to me. Ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/116#issuecomment-52880696
Hyunsik,
Could you take a look at this ?
Thanks
Failed tests: testIncrementOfUnicode(org.apache.tajo.engine.planner.TestUniformRangePartition): prev=(0=>##??), current=(0=>##??)
Tests in error:
testPartitionForUnicodeDiffLenEndTextAsc(org.apache.tajo.engine.planner.TestUniformRangePartition): Computed ranges are not totally ordered. Previous key=[(0=>##?), (0=>##??)), Current Key=[(0=>##??), (0=>##??))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1004: UniformRangePartition cannot deal wi...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/116#issuecomment-52168723
I've fixed wrong existing unit tests, and fixed some potential problems. It is ready to be reviewed and committed. Please review this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---