You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by rm...@apache.org on 2010/12/14 17:11:31 UTC
svn commit: r1049141 -
/incubator/isis/trunk/core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/value/ValueSemanticsProviderAbstractTemporal.java
Author: rmatthews
Date: Tue Dec 14 16:11:31 2010
New Revision: 1049141
URL: http://svn.apache.org/viewvc?rev=1049141&view=rev
Log:
Non-synchronized calls to format/parse methods could cause parse exceptions.
Modified:
incubator/isis/trunk/core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/value/ValueSemanticsProviderAbstractTemporal.java
Modified: incubator/isis/trunk/core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/value/ValueSemanticsProviderAbstractTemporal.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/value/ValueSemanticsProviderAbstractTemporal.java?rev=1049141&r1=1049140&r2=1049141&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/value/ValueSemanticsProviderAbstractTemporal.java (original)
+++ incubator/isis/trunk/core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/value/ValueSemanticsProviderAbstractTemporal.java Tue Dec 14 16:11:31 2010
@@ -245,6 +245,10 @@ public abstract class ValueSemanticsProv
@Override
protected String doEncode(final Object object) {
final Date date = dateValue(object);
+ return encode(date);
+ }
+
+ private synchronized String encode(final Date date) {
return encodingFormat.format(date);
}
@@ -254,7 +258,7 @@ public abstract class ValueSemanticsProv
cal.setTimeZone(UTC_TIME_ZONE);
try {
- cal.setTime(encodingFormat.parse(data));
+ cal.setTime(parse(data));
clearFields(cal);
return setDate(cal.getTime());
} catch (final ParseException e) {
@@ -269,6 +273,10 @@ public abstract class ValueSemanticsProv
}
}
+ private synchronized Date parse(final String data) throws ParseException {
+ return encodingFormat.parse(data);
+ }
+
// //////////////////////////////////////////////////////////////////
// DateValueFacet
// //////////////////////////////////////////////////////////////////