You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/05/08 22:19:58 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23975: feat: Allows dynamic type on viz migrations
michael-s-molina opened a new pull request, #23975:
URL: https://github.com/apache/superset/pull/23975
### SUMMARY
This PR modifies the viz migration base class to allow the target viz type to be defined dynamically during the migration itself. This is a prerequisite for some types of migrations such as the NVD3 Line chart which can be migrated into different ECharts charts such as Line, Smooth Line, Stepped Line, etc.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23975: feat: Allows dynamic type on viz migrations
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23975:
URL: https://github.com/apache/superset/pull/23975#issuecomment-1539147722
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23975](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1a7b48) into [master](https://app.codecov.io/gh/apache/superset/commit/b4371f68b77a98231619d0288578b49d57b21053?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4371f6) will **decrease** coverage by `11.37%`.
> The diff coverage is `92.88%`.
> :exclamation: Current head f1a7b48 differs from pull request most recent head 5e9fe8d. Consider uploading reports for the commit 5e9fe8d to get more accurate results
```diff
@@ Coverage Diff @@
## master #23975 +/- ##
===========================================
- Coverage 68.15% 56.79% -11.37%
===========================================
Files 1941 1941
Lines 75212 75213 +1
Branches 8158 8153 -5
===========================================
- Hits 51262 42717 -8545
- Misses 21867 30415 +8548
+ Partials 2083 2081 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| postgres | `?` | |
| presto | `53.09% <96.48%> (-0.01%)` | :arrow_down: |
| python | `59.25% <96.98%> (-23.46%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.98% <96.48%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.07% <ø> (-0.46%)` | :arrow_down: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `78.37% <ø> (ø)` | |
| [...uperset-frontend/src/hooks/apiResources/schemas.ts](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9zY2hlbWFzLnRz) | `50.00% <ø> (-42.31%)` | :arrow_down: |
| [superset-frontend/src/hooks/apiResources/tables.ts](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy90YWJsZXMudHM=) | `80.00% <ø> (-4.22%)` | :arrow_down: |
| [superset-frontend/src/views/App.tsx](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/views/store.ts](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3N0b3JlLnRz) | `78.26% <ø> (ø)` | |
| [superset/datasource/api.py](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNvdXJjZS9hcGkucHk=) | `55.26% <ø> (-44.74%)` | :arrow_down: |
| [superset/db\_engine\_specs/ocient.py](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL29jaWVudC5weQ==) | `57.28% <0.00%> (ø)` | |
| [superset/key\_value/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `45.83% <0.00%> (-47.92%)` | :arrow_down: |
| ... and [48 more](https://app.codecov.io/gh/apache/superset/pull/23975?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [265 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/23975/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23975: feat: Allows dynamic type on viz migrations
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23975:
URL: https://github.com/apache/superset/pull/23975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org