You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/17 19:51:37 UTC
[GitHub] [solr] janhoy opened a new pull request, #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
janhoy opened a new pull request, #1084:
URL: https://github.com/apache/solr/pull/1084
No JIRA
Just throwing this idea out there. Cannot see any reason to keep wget, gpg, dirmngr in the image?
```
After this operation, 3,579 kB disk space will be freed.
After this operation, 5,176 kB disk space will be freed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1281417709
I see that `Dockerfile.body.template` includes this line at the bottom:
```bash
apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \
```
...which installs both wget and dirmngr again. I see that a few of the `scripts/` use `wget`, so it probably needs to stay (unless we can convert them to using curl), but why do we need `dirmngr` in the image runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1282336082
I think coming up with multiple tags would be how to slim further. solr:9-slim solr:9, solr:9-andTika, solr:9-prometheus
And also, continue Solr-package investments to make it easier to "install".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1084:
URL: https://github.com/apache/solr/pull/1084#discussion_r998545994
##########
solr/docker/templates/Dockerfile.official.header.template:
##########
@@ -85,5 +85,6 @@ RUN set -ex; \
{ command -v gpgconf; gpgconf --kill all || :; }; \
rm -r "$GNUPGHOME"; \
tar -C /opt --extract --preserve-permissions --file "/opt/solr-$SOLR_VERSION.tgz"; \
- rm "/opt/solr-$SOLR_VERSION.tgz"*;
+ rm "/opt/solr-$SOLR_VERSION.tgz"*; \
+ apt -y remove wget gpg dirmngr && apt -y autoremove;
Review Comment:
No need to remove wget here when we install it again later. Use `apt-get` instead of `apt` for consistency within the file.
```suggestion
apt-get -y remove gpg dirmngr && apt-get -y autoremove;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1084:
URL: https://github.com/apache/solr/pull/1084#discussion_r998651789
##########
solr/docker/templates/Dockerfile.body.template:
##########
@@ -71,7 +71,7 @@ RUN set -ex; \
RUN set -ex; \
apt-get update; \
- apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \
+ apt-get -y install acl lsof procps wget netcat gosu tini jattach; \
Review Comment:
I ran `gradlew testDocker` and all tests passed even without `dirmngr` in the image. So I removed it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1282919985
@HoustonPutman do you recall why we have `dirmngr` in the last RUN command? I think perhaps it is a leftover from when splitting Dockerfile into templates for local and prod. Then you moved the `apt-get` from top of the old Dockerfile to later in the body. I'm going to try to remove it ans run all integration tests...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1282927034
Ahh didn't see your last change. But I don't remember off the top of my head. Probably test related, but I'm not confident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1282850908
I think at some point it is very useful to have a tool inside the container, either wget or curl, that lets us debug issues with Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1282230597
> Shaving MB usually gets my approval :-)
Sure. I hope we can use `jlink` in the future to shave off some JDK modules. The debian distro is already quite slim, but avoiding too many apt-get installs is important, they also drag in lib dependencies. However, removing less used jar dependencies from Solr is probably the main way to continue shaving. If only SolrCell could be a standalone project...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1281785959
Shaving MB usually gets my approval :-)
(I have no clue RE `dirmngr`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1084:
URL: https://github.com/apache/solr/pull/1084#issuecomment-1282917311
> I think at some point it is very useful to have a tool inside the container, either wget or curl, that lets us debug issues with Solr.
Agree very much. Now we have both. `wget` weighs less than 1Mb so not worth the effort to convert all scripts to using cURL I think. But it could be done if one wanted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1084: SOLR-16484 Remove gpg from image, slimming it down some Mb
Posted by GitBox <gi...@apache.org>.
janhoy merged PR #1084:
URL: https://github.com/apache/solr/pull/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org