You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2009/10/12 23:26:31 UTC

[jira] Created: (MAPREDUCE-1092) Enable asserts for tests by default

Enable asserts for tests by default
-----------------------------------

                 Key: MAPREDUCE-1092
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
             Project: Hadoop Map/Reduce
          Issue Type: Test
            Reporter: Eli Collins
         Attachments: hadoop6309-mapreduce.patch

See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

    Attachment: M1092-1.patch

This shouldn't be blocked on MAPREDUCE-1506. I propose disabling the failing tests in trunk for now and mark MAPREDUCE-1506 as a blocker in trunk. Sound fair?

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch, M1092-1.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864205#action_12864205 ] 

Hadoop QA commented on MAPREDUCE-1092:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch
  against trunk revision 940740.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/console

This message is automatically generated.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

    Status: Open  (was: Patch Available)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated MAPREDUCE-1092:
-------------------------------------

    Status: Patch Available  (was: Open)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated MAPREDUCE-1092:
---------------------------------

      Component/s: test
    Fix Version/s: 0.22.0

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835482#action_12835482 ] 

Aaron Kimball commented on MAPREDUCE-1092:
------------------------------------------

Per Vinod's comment on MAPREDUCE-1093, can we resolve this now, so as to include assertion checking on trunk by default? I'm going to mark the patch as available.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Eli Collins
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864531#action_12864531 ] 

Eli Collins commented on MAPREDUCE-1092:
----------------------------------------

+1 on M1092-2.patch.  Thanks Chris!

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch, M1092-1.patch, M1092-2.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835590#action_12835590 ] 

Vinod K V commented on MAPREDUCE-1092:
--------------------------------------

bq. can we resolve this now?
+1 assuming Hudson blesses it. If Hudson itself hits MAPREDUCE-1506, we will need to fix that first. I see that you have attached a failure trace there, I'll start digging into it.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Eli Collins
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated MAPREDUCE-1092:
-------------------------------------

    Status: Patch Available  (was: Open)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Eli Collins
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated MAPREDUCE-1092:
-----------------------------------

    Attachment: hadoop6309-mapreduce.patch

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Eli Collins
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835599#action_12835599 ] 

Aaron Kimball commented on MAPREDUCE-1092:
------------------------------------------

I'll point out that MAPREDUCE-1506 is intermittent; I hit this roughly 90% of the time on my own machine, but I think it's a race condition of some sort.  There are times when back-to-back tests do not trigger a reproduction. It might not manifest on Hudson at all on the first pass, but that's no guarantee either way for subsequent runs.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated MAPREDUCE-1092:
-------------------------------------

    Status: Open  (was: Patch Available)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

    Attachment: M1092-2.patch

Made a property of the junit args.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch, M1092-1.patch, M1092-2.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764892#action_12764892 ] 

Eli Collins commented on MAPREDUCE-1092:
----------------------------------------

Two java asserts in tests fail when running with this patch, filed MAPREDUCE-1093 for them.  TestCopyFiles also failed, but that's MAPREDUCE-1029.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Eli Collins
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847752#action_12847752 ] 

Hadoop QA commented on MAPREDUCE-1092:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch
  against trunk revision 925554.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/console

This message is automatically generated.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

    Status: Patch Available  (was: Open)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas reassigned MAPREDUCE-1092:
----------------------------------------

    Assignee: Eli Collins

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch, M1092-1.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

+1

I committed this. Thanks, Eli!

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch, M1092-1.patch, M1092-2.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

    Status: Patch Available  (was: Open)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848545#action_12848545 ] 

Hadoop QA commented on MAPREDUCE-1092:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch
  against trunk revision 926411.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/console

This message is automatically generated.

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1092:
-------------------------------------

    Status: Open  (was: Patch Available)

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1092) Enable asserts for tests by default

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864505#action_12864505 ] 

Eli Collins commented on MAPREDUCE-1092:
----------------------------------------

Sounds good to me. 

> Enable asserts for tests by default
> -----------------------------------
>
>                 Key: MAPREDUCE-1092
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1092
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: hadoop6309-mapreduce.patch, M1092-1.patch
>
>
> See HADOOP-6309. Let's make the tests run with java asserts by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.