[GitHub] [hudi] danny0405 commented on a change in pull request #3468: [HUDI-2306] Support setting whether drop duplicate based on table typ…

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #3468:
URL: https://github.com/apache/hudi/pull/3468#discussion_r688397803



##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -115,8 +115,8 @@ private FlinkOptions() {
   public static final ConfigOption<Double> INDEX_STATE_TTL = ConfigOptions
       .key("index.state.ttl")
       .doubleType()
-      .defaultValue(1.5D)
-      .withDescription("Index state ttl in days, default 1.5 day");
+      .defaultValue(0D)
+      .withDescription("Index state ttl in days, default 0 day");
 

Review comment:
       default store the index forever

##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##########
@@ -227,6 +229,16 @@ private static void setupHiveOptions(Configuration conf) {
     }
   }
 
+  /**
+   * Sets up write options from the table definition.
+   * */
+  private static void setupWriteOptions(Configuration conf, CatalogTable table) {
+    // sets up dropDuplicate options
+    if (conf.getString(FlinkOptions.TABLE_TYPE).equals(FlinkOptions.TABLE_TYPE_COPY_ON_WRITE)) {
+      conf.setBoolean(FlinkOptions.INSERT_DROP_DUPS, true);

Review comment:
       equalsIgnoreCase




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org