[GitHub] [arrow] pitrou commented on a diff in pull request #13383: ARROW-16769: [C++] Add Warn() function to Status

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13383:
URL: https://github.com/apache/arrow/pull/13383#discussion_r898884145


##########
cpp/src/arrow/status.cc:
##########
@@ -131,6 +131,13 @@ void Status::Abort(const std::string& message) const {
   std::abort();
 }
 
+void Status::Warn() const { Warn(std::string()); }
+
+void Status::Warn(const std::string& message) const {
+  ARROW_LOG(WARNING) << "Arrow Warning -- "

Review Comment:
   I don't think you need to add the "Arrow Warning" phrase. Instead that should be handled by `ARROW_LOG` itself, or whatever it redirects to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org