You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cassandra.apache.org by Jack Krupansky <ja...@gmail.com> on 2016/04/19 16:57:44 UTC

Typo in comment for maxFunctionForCounter in AggregateFcts.java

Comment typo for maxFunctionForCounter in AggregateFcts.java:

    /**
     * AVG function for counter column values.
     */
    public static final AggregateFunction maxFunctionForCounter =
    new NativeAggregateFunction("max", CounterColumnType.instance,
CounterColumnType.instance)

That comment should be "MAX" rather than "AVG"

See:
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760

Oops... I see more copy and paste typos, where the type for the function is
wrong in the comment:
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398

Let me know if this needs a Jia ticket or if somebody can just fix it
without the paperwork.

-- Jack Krupansky

Re: Typo in comment for maxFunctionForCounter in AggregateFcts.java

Posted by Jack Krupansky <ja...@gmail.com>.

Thanks for the prompt service!

-- Jack Krupansky

On Tue, Apr 19, 2016 at 12:16 PM, Benjamin Lerer <
benjamin.lerer@datastax.com> wrote:

> Done. Thanks for reporting the problem.
>
> On Tuesday, April 19, 2016, Benjamin Lerer <be...@datastax.com>
> wrote:
>
> > I will fix it. I am the one that has probably done them anyway.
> >
> > Benjamin
> >
> > On Tue, Apr 19, 2016 at 4:57 PM, Jack Krupansky <
> jack.krupansky@gmail.com
> > <javascript:_e(%7B%7D,'cvml','jack.krupansky@gmail.com');>> wrote:
> >
> >> Comment typo for maxFunctionForCounter in AggregateFcts.java:
> >>
> >>     /**
> >>      * AVG function for counter column values.
> >>      */
> >>     public static final AggregateFunction maxFunctionForCounter =
> >>     new NativeAggregateFunction("max", CounterColumnType.instance,
> >> CounterColumnType.instance)
> >>
> >> That comment should be "MAX" rather than "AVG"
> >>
> >> See:
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
> >>
> >> Oops... I see more copy and paste typos, where the type for the function
> >> is
> >> wrong in the comment:
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
> >>
> >>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
> >>
> >> Let me know if this needs a Jia ticket or if somebody can just fix it
> >> without the paperwork.
> >>
> >> -- Jack Krupansky
> >>
> >
> >
>

Re: Typo in comment for maxFunctionForCounter in AggregateFcts.java

Posted by Benjamin Lerer <be...@datastax.com>.

Done. Thanks for reporting the problem.

On Tuesday, April 19, 2016, Benjamin Lerer <be...@datastax.com>
wrote:

> I will fix it. I am the one that has probably done them anyway.
>
> Benjamin
>
> On Tue, Apr 19, 2016 at 4:57 PM, Jack Krupansky <jack.krupansky@gmail.com
> <javascript:_e(%7B%7D,'cvml','jack.krupansky@gmail.com');>> wrote:
>
>> Comment typo for maxFunctionForCounter in AggregateFcts.java:
>>
>>     /**
>>      * AVG function for counter column values.
>>      */
>>     public static final AggregateFunction maxFunctionForCounter =
>>     new NativeAggregateFunction("max", CounterColumnType.instance,
>> CounterColumnType.instance)
>>
>> That comment should be "MAX" rather than "AVG"
>>
>> See:
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
>>
>> Oops... I see more copy and paste typos, where the type for the function
>> is
>> wrong in the comment:
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
>>
>> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
>>
>> Let me know if this needs a Jia ticket or if somebody can just fix it
>> without the paperwork.
>>
>> -- Jack Krupansky
>>
>
>

Re: Typo in comment for maxFunctionForCounter in AggregateFcts.java

Posted by Benjamin Lerer <be...@datastax.com>.

I will fix it. I am the one that has probably done them anyway.

Benjamin

On Tue, Apr 19, 2016 at 4:57 PM, Jack Krupansky <ja...@gmail.com>
wrote:

> Comment typo for maxFunctionForCounter in AggregateFcts.java:
>
>     /**
>      * AVG function for counter column values.
>      */
>     public static final AggregateFunction maxFunctionForCounter =
>     new NativeAggregateFunction("max", CounterColumnType.instance,
> CounterColumnType.instance)
>
> That comment should be "MAX" rather than "AVG"
>
> See:
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L760
>
> Oops... I see more copy and paste typos, where the type for the function is
> wrong in the comment:
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L284
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L320
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L362
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/AggregateFcts.java#L398
>
> Let me know if this needs a Jia ticket or if somebody can just fix it
> without the paperwork.
>
> -- Jack Krupansky
>