You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2024/09/18 16:05:34 UTC
(royale-compiler) 09/12: ConstantLogic: warning for boolean constant compared with null
This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
commit 3c1fbb0edf1bd691fa535cc05aba541ce23c79bc
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Tue Sep 17 14:34:55 2024 -0700
ConstantLogic: warning for boolean constant compared with null
---
.../compiler/internal/as/codegen/ConstantLogic.jbg | 48 ++++++++++++++++++----
1 file changed, 40 insertions(+), 8 deletions(-)
diff --git a/compiler/src/main/jburg/org/apache/royale/compiler/internal/as/codegen/ConstantLogic.jbg b/compiler/src/main/jburg/org/apache/royale/compiler/internal/as/codegen/ConstantLogic.jbg
index fbaec8fc9..2ebff2625 100644
--- a/compiler/src/main/jburg/org/apache/royale/compiler/internal/as/codegen/ConstantLogic.jbg
+++ b/compiler/src/main/jburg/org/apache/royale/compiler/internal/as/codegen/ConstantLogic.jbg
@@ -96,7 +96,11 @@
boolean_constant=
Op_EqualID(boolean_constant l, constant_value r) : 0
{
- if (r == UNDEFINED_VALUE)
+ if (r == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (r == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -106,7 +110,11 @@
boolean_constant=
Op_EqualID(constant_value l, boolean_constant r) : 0
{
- if (l == UNDEFINED_VALUE)
+ if (l == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (l == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -173,7 +181,11 @@
boolean_constant=
Op_StrictEqualID(boolean_constant l, constant_value r) : 0
{
- if (r == UNDEFINED_VALUE)
+ if (r == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (r == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -183,7 +195,11 @@
boolean_constant=
Op_StrictEqualID(constant_value l, boolean_constant r) : 0
{
- if (l == UNDEFINED_VALUE)
+ if (l == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (l == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -247,7 +263,11 @@
boolean_constant=
Op_NotEqualID(boolean_constant l, constant_value r) : 0
{
- if (r == UNDEFINED_VALUE)
+ if (r == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (r == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -257,7 +277,11 @@
boolean_constant=
Op_NotEqualID(constant_value l, boolean_constant r) : 0
{
- if (l == UNDEFINED_VALUE)
+ if (l == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (l == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -323,7 +347,11 @@
boolean_constant=
Op_StrictNotEqualID(boolean_constant l, constant_value r) : 0
{
- if (r == UNDEFINED_VALUE)
+ if (r == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (r == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}
@@ -333,7 +361,11 @@
boolean_constant=
Op_StrictNotEqualID(constant_value l, boolean_constant r) : 0
{
- if (l == UNDEFINED_VALUE)
+ if (l == NULL_VALUE)
+ {
+ recordError(new ComparisonBetweenUnrelatedTypesProblem(__p, "Boolean", "null"));
+ }
+ else if (l == UNDEFINED_VALUE)
{
recordError(new IllogicalComparisonWithUndefinedProblem(__p));
}