You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 19:36:48 UTC
[GitHub] [arrow-datafusion] Dandandan opened a new pull request #261: Enable redundant_field_names clippy lint
Dandandan opened a new pull request #261:
URL: https://github.com/apache/arrow-datafusion/pull/261
# Which issue does this PR close?
Closes #260
# Rationale for this change
This lint doesn't seem to cause warnings in our code. If we have some linting error, we should not put it here but on a more granular (line/code block/module/project) level, so the warnings locally reflect te CI
# What changes are included in this PR?
Remove the "allow" on the lint
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #261: Enable redundant_field_names clippy lint
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #261:
URL: https://github.com/apache/arrow-datafusion/pull/261#issuecomment-832201536
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/261?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#261](https://codecov.io/gh/apache/arrow-datafusion/pull/261?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3a0efc) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/5f6024d570f4d2d5fd4c2187ff7dcb0cd389ac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f6024d) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 133 133
Lines 23284 23284
=======================================
Hits 17884 17884
Misses 5400 5400
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/261?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/261?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5f6024d...a3a0efc](https://codecov.io/gh/apache/arrow-datafusion/pull/261?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #261: Enable redundant_field_names clippy lint
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #261:
URL: https://github.com/apache/arrow-datafusion/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #261: Enable redundant_field_names clippy lint
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #261:
URL: https://github.com/apache/arrow-datafusion/pull/261#issuecomment-832623685
Thanks @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org