You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by ov...@apache.org on 2020/12/29 09:03:14 UTC
[incubator-echarts] branch feat-bar-race created (now dd74d64)
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a change to branch feat-bar-race
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.
at dd74d64 fix(bar-race): fix when no oldOrder
This branch includes the following new commits:
new dd74d64 fix(bar-race): fix when no oldOrder
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[incubator-echarts] 01/01: fix(bar-race): fix when no oldOrder
Posted by ov...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch feat-bar-race
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit dd74d642660d36c47d46dadc37a892e6d9614086
Author: Ovilia <zw...@gmail.com>
AuthorDate: Tue Dec 29 17:02:24 2020 +0800
fix(bar-race): fix when no oldOrder
---
src/chart/bar/BarView.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/chart/bar/BarView.ts b/src/chart/bar/BarView.ts
index aca98c5..af18c62 100644
--- a/src/chart/bar/BarView.ts
+++ b/src/chart/bar/BarView.ts
@@ -512,7 +512,7 @@ class BarView extends ChartView {
* bars are both out of sight, we don't wish to trigger reorder action
* as long as the order in the view doesn't change.
*/
- if (!oldOrder[i] || oldOrder[i].ordinalNumber !== newOrder[i].ordinalNumber) {
+ if (!oldOrder || !oldOrder[i] || oldOrder[i].ordinalNumber !== newOrder[i].ordinalNumber) {
this.removeOnRenderedListener(api);
const action = {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org