You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/03 01:27:00 UTC

[jira] [Commented] (AIRFLOW-3434) SFTPOperator does not create intermediate directories

    [ https://issues.apache.org/jira/browse/AIRFLOW-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706578#comment-16706578 ] 

ASF GitHub Bot commented on AIRFLOW-3434:
-----------------------------------------

kaxil opened a new pull request #4270: [AIRFLOW-3434] Allows creating intermediate folders in SFTPOperator
URL: https://github.com/apache/incubator-airflow/pull/4270
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3434
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   This PR adds the feature to create the intermediate directories when copying to/from the remote host.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   - `test_file_transfer_no_intermediate_dir_error_put`
   - `test_file_transfer_with_intermediate_dir_error_put`
   - `test_file_transfer_no_intermediate_dir_error_get`
   - `test_file_transfer_with_intermediate_dir_error_get`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SFTPOperator does not create intermediate directories
> -----------------------------------------------------
>
>                 Key: AIRFLOW-3434
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3434
>             Project: Apache Airflow
>          Issue Type: New Feature
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 1.10.2
>
>
> When using SFTPOperator with either 'get' or 'put', it doesn't create the intermediate directories when copying the file and fails with directory does not exist.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)