You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by selvaganesang <gi...@git.apache.org> on 2017/10/09 23:42:22 UTC
[GitHub] incubator-trafodion pull request #1260: [TRAFODION-2768] Make Trafodion code...
GitHub user selvaganesang opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1260
[TRAFODION-2768] Make Trafodion code base to compile in RH7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/selvaganesang/incubator-trafodion rh7_build_issues
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1260
----
commit ec9ec1711b5ac977d89196e477ff1fb21db8a2ba
Author: selvaganesang <se...@esgyn.com>
Date: 2017-10-09T23:37:51Z
[TRAFODION-2768] Make Trafodion code base to compile in RH7
----
---
[GitHub] incubator-trafodion pull request #1260: [TRAFODION-2768] Make Trafodion code...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1260
---
[GitHub] incubator-trafodion pull request #1260: [TRAFODION-2768] Make Trafodion code...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1260#discussion_r143764664
--- Diff: core/sqf/src/tm/tm.cpp ---
@@ -460,9 +460,13 @@ void tm_process_req_requestregioninfo(CTmTxMessage * pp_msg)
TM_Txid_legacy lv_transid;
} u;
- char tname[2000], ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
+ char tname[2000];
+ tname[299] = '\0';
--- End diff --
Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before.
---