You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrey Chernyshev (JIRA)" <ji...@apache.org> on 2006/07/04 19:15:29 UTC
[jira] Created: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
DRLVM build cleanup: remove some of classlib tasks
--------------------------------------------------
Key: HARMONY-753
URL: http://issues.apache.org/jira/browse/HARMONY-753
Project: Harmony
Type: Improvement
Components: VM
Reporter: Andrey Chernyshev
Priority: Minor
Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
Remove the following files/components:
make/components/extra/icu4c.xml
make/components/extra/resolver.xml
make/components/extra/serializer.xml
make/components/extra/xml_api_copy.xml
- these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
Remove the following target:
make/targets/common_classlib.xml
- contained the common logic needed to compile class libraries, we no longer need it in VM build;
Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Andrey Chernyshev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=comments#action_12419284 ]
Andrey Chernyshev commented on HARMONY-753:
-------------------------------------------
After I removed common_classlib.xml build started to complain that "java.source.pattern" is undefined during the apr component compliation. I thought this could be a bug in the build, the APR and classlib compliation should have been done independently and the source pattern defined in one component should not have been reused by the other.
Anyways, I thought it may be good idea to move the definition of java.classes.pattern and java.source.pattern from kernel classes up to the build.java.xml since it is most likely will be applicable now for all java compilation tasks regardless of the component. Sorry for not mentioning this in the description of the patch.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Andrey Chernyshev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=comments#action_12419496 ]
Andrey Chernyshev commented on HARMONY-753:
-------------------------------------------
Looks OK.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=all ]
Mark Hindess resolved HARMONY-753:
----------------------------------
Resolution: Fixed
Sorry for all the questions. Applied in r419262. Please verify that it has been applied as expected.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=all ]
Mark Hindess closed HARMONY-753:
--------------------------------
Verified by Andrey.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=all ]
Mark Hindess reassigned HARMONY-753:
------------------------------------
Assign To: Mark Hindess
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=comments#action_12419182 ]
Mark Hindess commented on HARMONY-753:
--------------------------------------
Andrey, I don't quite understand this patch. For instance, you didn't mention bcprov above but you remove some references to it in build/make/components/extra.xml and build/make/deploy.xml and confusingly the patch doesn't remove build/make/components/extra/bcprov.xml ?
This seems a little inconsistent. Perhaps I'm missing something.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Andrey Chernyshev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=all ]
Andrey Chernyshev updated HARMONY-753:
--------------------------------------
Attachment: classlib-cleanup.patch
Patch that removes some of classlib-related tasks from drlvm build.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=comments#action_12419279 ]
Mark Hindess commented on HARMONY-753:
--------------------------------------
Sorry, Andrey, can you explain how the changes in:
build/make/components/vm/kernel_classes.xml
build/make/targets/build.java.xml
relate to this issue?
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-753) DRLVM build cleanup: remove some of
classlib tasks
Posted by "Andrey Chernyshev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-753?page=comments#action_12419258 ]
Andrey Chernyshev commented on HARMONY-753:
-------------------------------------------
Mark, you are right - I forgot to remove bcprov.xml in this patch, thanks for noting this. bcprov.jar is also copied from the class libraries now in the deploy.copy_classlib target, it doesn't have to be copied again in the extra/bcprov.xml. bcprov.xml file can be deleted as well.
> DRLVM build cleanup: remove some of classlib tasks
> --------------------------------------------------
>
> Key: HARMONY-753
> URL: http://issues.apache.org/jira/browse/HARMONY-753
> Project: Harmony
> Type: Improvement
> Components: VM
> Reporter: Andrey Chernyshev
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: classlib-cleanup.patch
>
> Once we agreed that DRLVM build has to contain only VM-related tasks, I've looked what of the classlib-related building code can be removed from drlvm build. The patch will suggest the following:
> Remove the following files/components:
> make/components/extra/icu4c.xml
> make/components/extra/resolver.xml
> make/components/extra/serializer.xml
> make/components/extra/xml_api_copy.xml
> - these libraries are now taken from the pre-built classlibraries during the bulk copy (which Geir added)
> Remove the following target:
> make/targets/common_classlib.xml
> - contained the common logic needed to compile class libraries, we no longer need it in VM build;
> Other minor changes were done accordingly to accomodate the removal of the above makefiles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira