You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sharmarke Aden (JIRA)" <ji...@codehaus.org> on 2006/05/17 21:00:41 UTC

[jira] Created: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Maven Archiver deleteing already existing pom.properties file.
--------------------------------------------------------------

         Key: MNG-2301
         URL: http://jira.codehaus.org/browse/MNG-2301
     Project: Maven 2
        Type: Bug

  Components: maven-archiver  
    Versions: 2.0.4    
    Reporter: Sharmarke Aden
 Attachments: maven-archiver_pomDelete.patch

My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 

Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2301?page=all ]

John Casey updated MNG-2301:
----------------------------

    Fix Version: 2.0.5

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>          Key: MNG-2301
>          URL: http://jira.codehaus.org/browse/MNG-2301
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0.4
>     Reporter: Sharmarke Aden
>      Fix For: 2.0.5
>  Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-2301:
------------------------------

    Fix Version/s:     (was: 2.0.x)

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>                 Key: MNG-2301
>                 URL: http://jira.codehaus.org/browse/MNG-2301
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.0.4
>            Reporter: Sharmarke Aden
>         Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "Jochen Wiedmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_89094 ] 

Jochen Wiedmann commented on MNG-2301:
--------------------------------------

Please note MNG-2854 (I have created a new bug report, because my issue is the failing uptodate check, which isn't necessarily the same problem than here. Additionally, the suggested solutions are quite different. Nevertheless, it should be possible to close either MNG-2854 (this issue) or MNG-2301 as a duplicate of the other.

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>                 Key: MNG-2301
>                 URL: http://jira.codehaus.org/browse/MNG-2301
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Sharmarke Aden
>             Fix For: 2.0.x
>
>         Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "Sharmarke Aden (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2301?page=comments#action_68282 ] 

Sharmarke Aden commented on MNG-2301:
-------------------------------------

The rational  behind not deleting the pom.properties files are:

1) Implicitly deleting a file explicitly created by the user is bad policy.

2) The idea behind not deleting the pom.properties is to facilitate external systems such as build systems to interact with maven. For example, communicating build number and date. The build system would place the build number in the pom.properties file and the maven can pickup this build information from the pom.properties file. Basically, this fix is necessary to support maven built-in properties enhancement request (see http://jira.codehaus.org/browse/MNG-1832).

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>          Key: MNG-2301
>          URL: http://jira.codehaus.org/browse/MNG-2301
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0.4
>     Reporter: Sharmarke Aden
>      Fix For: 2.0.5
>  Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2301?page=comments#action_67949 ] 

John Casey commented on MNG-2301:
---------------------------------

IMO, this could be a vector for introducing false data which may eventually be depended upon (even unintentionally)...I'd tend to say that this file should *always* be generated.

What reason do you have for doing this?



> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>          Key: MNG-2301
>          URL: http://jira.codehaus.org/browse/MNG-2301
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0.4
>     Reporter: Sharmarke Aden
>  Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2301?page=all ]

Kenney Westerhof updated MNG-2301:
----------------------------------

    Fix Version/s:     (was: 2.0.5)
                   2.0.6

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>                 Key: MNG-2301
>                 URL: http://jira.codehaus.org/browse/MNG-2301
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Sharmarke Aden
>             Fix For: 2.0.6
>
>         Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "Nigel Magnay (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90505 ] 

Nigel Magnay commented on MNG-2301:
-----------------------------------

> IMO, this could be a vector for introducing false data which may eventually be depended upon (even unintentionally)...I'd tend to say that this file should always be generated.

This seems right to me - it sounds like the fix in MNG-2854 also helps with this by moving the pom.properties artifact into a target subdirectory, which seems right. That way even if it doesn't get deleted, you know that it's always generated, and the risk that you're taking.

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>                 Key: MNG-2301
>                 URL: http://jira.codehaus.org/browse/MNG-2301
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Sharmarke Aden
>             Fix For: 2.0.x
>
>         Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-2301) Maven Archiver deleteing already existing pom.properties file.

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl closed MNG-2301.
------------------------------

    Resolution: Won't Fix

The pom.properties is Maven's domain and is always generated. You need to use something else if you want to introduce your own data.

> Maven Archiver deleteing already existing pom.properties file.
> --------------------------------------------------------------
>
>                 Key: MNG-2301
>                 URL: http://jira.codehaus.org/browse/MNG-2301
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Sharmarke Aden
>             Fix For: 2.0.x
>
>         Attachments: maven-archiver_pomDelete.patch
>
>
> My project has it's own pom.properties file and it seems that maven archiver is deleting it right after packaging the application. Any particular reason why it's doing this? It seems to me the archiver shouldn't be deleting the file if it already exists. It should delete the file if it doesn't exists otherwise it should add the necessary information (version, groupId, etc) to the file and leave it be. I have attached a patch that fixes the issue. 
> Also note that this patch adds the "builtOn" property to the pom.properties which is satisfy the following enhancement request: http://jira.codehaus.org/browse/MNG-1830 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira