You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2023/01/11 21:20:49 UTC
[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #1937: Improved user agent handling of cases where gremlin version is not available
Cole-Greer opened a new pull request, #1937:
URL: https://github.com/apache/tinkerpop/pull/1937
It was observed in the java driver that the UserAgent class could fail to load if the manifest file was excluded from the jar. This is because the user agent relies on the manifest to extract the current version of gremlin. This PR adds a bit of extra error handling and will insert a value of "NotAvailable" in case of any failures. A similar issue was also present in JS which is also fixed here.
Thanks @kenhuuu for discovering this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1937: Improved user agent handling of cases where gremlin version is not available
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1379512109
Thank you Cole!
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1937: Improved user agent handling of cases where gremlin version is not available
Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1379650714
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1937: Improved user agent handling of cases where gremlin version is not available
Posted by GitBox <gi...@apache.org>.
lyndonbauto commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1382577163
VOTE+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1937: Improved user agent handling of cases where gremlin version is not available
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1379531910
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1937](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcfcc34) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b8e6b2827d68bfbc73205df00f201a0e75bd7ca2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8e6b28) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1937 +/- ##
=============================================
+ Coverage 69.29% 69.32% +0.02%
- Complexity 8937 8948 +11
=============================================
Files 865 865
Lines 41086 41087 +1
Branches 5417 5417
=============================================
+ Hits 28472 28483 +11
+ Misses 10696 10690 -6
+ Partials 1918 1914 -4
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/tinkerpop/gremlin/driver/UserAgent.java](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Vc2VyQWdlbnQuamF2YQ==) | `92.85% <100.00%> (+15.93%)` | :arrow_up: |
| [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `90.45% <0.00%> (+0.54%)` | :arrow_up: |
| [...e/tinkerpop/gremlin/server/util/MetricManager.java](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL01ldHJpY01hbmFnZXIuamF2YQ==) | `52.45% <0.00%> (+0.54%)` | :arrow_up: |
| [...rg/apache/tinkerpop/gremlin/driver/Connection.java](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uLmphdmE=) | `63.12% <0.00%> (+0.62%)` | :arrow_up: |
| [...kergraph/process/computer/TinkerGraphComputer.java](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy9jb21wdXRlci9UaW5rZXJHcmFwaENvbXB1dGVyLmphdmE=) | `93.89% <0.00%> (+0.76%)` | :arrow_up: |
| [...emlin/process/computer/util/VertexProgramPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3V0aWwvVmVydGV4UHJvZ3JhbVBvb2wuamF2YQ==) | `52.38% <0.00%> (+9.52%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk merged pull request #1937: Improved user agent handling of cases where gremlin version is not available
Posted by GitBox <gi...@apache.org>.
vkagamlyk merged PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org