[GitHub] [incubator-livy] yantzu commented on a change in pull request #207: [LIVY-645]Add Session Name, Owner, Proxy User information to Web UI

[GitBox <gi...@apache.org>]

yantzu commented on a change in pull request #207: [LIVY-645]Add Session Name, Owner, Proxy User information to Web UI
URL: https://github.com/apache/incubator-livy/pull/207#discussion_r320620874
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/server/batch/BatchSessionServlet.scala
 ##########
 @@ -73,8 +75,8 @@ class BatchSessionServlet(
       } else {
         Nil
       }
-    BatchSessionView(session.id, session.name, session.state.toString, session.appId,
-      session.appInfo, logs)
+    BatchSessionView(session.id, session.name, session.owner, session.proxyUser,
+      session.state.toString, session.appId, session.appInfo, logs)
 
 Review comment:
   Hi @jerryshao , sorry for late. My consideration is:
   1, I use Option[String] as proxyUser type is because BatchRecoveryMetadata's proxyUser is Option[String]. And name, appId are Option[String], my purpose it to make them consistent. Interactive session is a little different because its SessionInfo class is Java
   2, The only field batch session doesn't have is "kind", which is a legacy field, batch session doesn't have the field information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services